14869 Declare refreshable modifiers on list views

Previously we had to put our refreshable modifiers higher in the heirarchy than the views they were refreshing, because we changed the state to `loading` when we pulled to refresh. This change of state cancelled the pull to refresh network task.

The state change for refresh was removed in 01cfd95fbd01e45e4a63982390787ab00bd15e84, and now we can group the refreshable control more closely with the list view it relates to.

Author: joshheald

WooCommerce/Classes/POS/Presentation/Item Selector/ChildItemList.swift

@@ -67,6 +67,10 @@ private extension ChildItemList {
             ItemList(state: state,
                      node: .parent(parentItem))
                 .transition(.opacity)
+                .refreshable {
+                    ServiceLocator.analytics.track(.pointOfSaleVariationsPullToRefresh)
+                    await posModel.refreshItems(base: .parent(parentItem))
+                }
         }
     }
 

WooCommerce/Classes/POS/Presentation/ItemListView.swift

@@ -138,17 +138,17 @@ private extension ItemListView {
                 bannerCardView
             }
         }
+        .refreshable {
+            ServiceLocator.analytics.track(.pointOfSaleProductsPullToRefresh)
+            await posModel.refreshItems(base: .root)
+        }
     }
 
     @ViewBuilder
     func childListView(parentItem: POSItem) -> some View {
         switch parentItem {
         case let .variableParentProduct(parentProduct):
             ChildItemList(parentItem: parentItem, title: parentProduct.name)
-                .refreshable {
-                    ServiceLocator.analytics.track(.pointOfSaleVariationsPullToRefresh)
-                    await posModel.refreshItems(base: .parent(parentItem))
-                }
         default:
             EmptyView()
         }

WooCommerce/Classes/POS/Presentation/PointOfSaleDashboardView.swift

@@ -88,10 +88,6 @@ struct PointOfSaleDashboardView: View {
             HStack {
                 if posModel.orderStage == .building {
                     ItemListView()
-                        .refreshable {
-                            ServiceLocator.analytics.track(.pointOfSaleProductsPullToRefresh)
-                            await posModel.refreshItems(base: .root)
-                        }
                         .accessibilitySortPriority(2)
                         .transition(.move(edge: .leading))
                 }