Merge pull request #6331 from woocommerce/issue/6324-hotfix-coupon-empty-state-view

Coupons: Hotfix empty state view for the coupon list

Author: itsmeichigo

WooCommerce/Classes/ViewRelated/Coupons/CouponListView.swift

@@ -7,6 +7,7 @@ struct CouponListView: UIViewControllerRepresentable {
 
     class Coordinator {
         var parentObserver: NSKeyValueObservation?
+        var rightBarButtonItemsObserver: NSKeyValueObservation?
     }
 
     /// This is a UIKit solution for fixing Navigation Title and Bar Button Items ignored in NavigationView.
@@ -20,6 +21,12 @@ struct CouponListView: UIViewControllerRepresentable {
             vc.parent?.navigationItem.title = vc.title
             vc.parent?.navigationItem.rightBarButtonItems = vc.navigationItem.rightBarButtonItems
         })
+
+        // This fixes the issue when `rightBarButtonItem` is updated in `CouponListViewController`,
+        // the hosting controller should be updated to reflect the change.
+        context.coordinator.rightBarButtonItemsObserver = viewController.observe(\.navigationItem.rightBarButtonItems, changeHandler: { vc, _ in
+            vc.parent?.navigationItem.rightBarButtonItems = vc.navigationItem.rightBarButtonItems
+        })
         return viewController
     }
 

WooCommerce/Classes/ViewRelated/Coupons/CouponListViewController.swift

@@ -85,6 +85,16 @@ final class CouponListViewController: UIViewController {
             }
             .store(in: &subscriptions)
 
+        viewModel.$couponViewModels
+            .map { viewModels -> Bool in
+                viewModels.isNotEmpty
+            }
+            .removeDuplicates()
+            .sink { [weak self] hasData in
+                self?.configureNavigationBarItems(hasCoupons: hasData)
+            }
+            .store(in: &subscriptions)
+
         // Call this after the state subscription for extra safety
         viewModel.viewDidLoad()
     }
@@ -148,7 +158,10 @@ extension CouponListViewController: UITableViewDelegate {
 private extension CouponListViewController {
     func configureNavigation() {
         title = Localization.title
-        navigationItem.rightBarButtonItem = searchBarButtonItem
+    }
+
+    func configureNavigationBarItems(hasCoupons: Bool) {
+        navigationItem.rightBarButtonItems = hasCoupons ? [searchBarButtonItem] : []
     }
 
     func configureTableView() {
@@ -208,11 +221,10 @@ extension CouponListViewController {
     ///
     func displayNoResultsOverlay() {
         let emptyStateViewController = EmptyStateViewController(style: .list)
-        let config = EmptyStateViewController.Config.withButton(
+        let config = EmptyStateViewController.Config.simple(
             message: .init(string: Localization.emptyStateMessage),
-            image: .emptyCouponsImage,
-            details: Localization.emptyStateDetails,
-            buttonTitle: Localization.addCouponButton) { _ in }
+            image: .emptyCouponsImage
+        )
 
         displayEmptyStateViewController(emptyStateViewController)
         emptyStateViewController.configure(config)
@@ -284,15 +296,9 @@ private extension CouponListViewController {
             comment: "Coupon management coupon list screen title")
 
         static let emptyStateMessage = NSLocalizedString(
-            "Everyone loves a deal",
+            "No coupons found",
             comment: "The title on the placeholder overlay when there are no coupons on the coupon list screen.")
 
-        static let emptyStateDetails = NSLocalizedString(
-            "Boost your business by sending customers special offers and discounts.",
-            comment: "The description on the placeholder overlay when there are no coupons on the coupon list screen.")
-
-        static let addCouponButton = NSLocalizedString("Add Coupon", comment: "Title for the action button to add coupon on the coupon list screen.")
-
         static let accessibilityLabelSearchCoupons = NSLocalizedString("Search coupons", comment: "Accessibility label for the Search Coupons button")
         static let accessibilityHintSearchCoupons = NSLocalizedString(
             "Retrieves a list of coupons that contain a given keyword.",

WooCommerce/Classes/ViewRelated/Coupons/CouponListViewModel.swift

@@ -23,7 +23,7 @@ final class CouponListViewModel {
 
     /// couponViewModels: ViewModels for the cells representing Coupons
     ///
-    var couponViewModels: [CouponListCellViewModel] = []
+    @Published private(set) var couponViewModels: [CouponListCellViewModel] = []
 
     /// siteID: siteID of the currently active site, used for fetching and storing coupons
     ///