Merge pull request #6948 from woocommerce/fix/warnings-in-xcode-13.3.1

Fix warnings in xcode 13.3.1

Author: joshheald

WooCommerce/Classes/Extensions/UIViewController+Helpers.swift

@@ -24,12 +24,15 @@ extension UIViewController {
 
     /// Show the X close button or a custom close button with title on the left bar button item position
     ///
-    func addCloseNavigationBarButton(title: String? = nil, target: Any? = self, action: Selector? = #selector(dismissVC)) {
+    func addCloseNavigationBarButton(title: String? = nil, target: Any? = nil, action: Selector? = #selector(dismissVC)) {
+        /// We can't make self the default value for the `target` parameter without a warning being added.
+        /// The compiler-recommended fix for the warning causes a crash when the button is tapped.
+        let targetOrSelf = target ?? self
         if let title = title {
-            navigationItem.leftBarButtonItem = UIBarButtonItem(title: title, style: .plain, target: target, action: action)
+            navigationItem.leftBarButtonItem = UIBarButtonItem(title: title, style: .plain, target: targetOrSelf, action: action)
         }
         else {
-            navigationItem.leftBarButtonItem = UIBarButtonItem(image: .closeButton, style: .plain, target: target, action: action)
+            navigationItem.leftBarButtonItem = UIBarButtonItem(image: .closeButton, style: .plain, target: targetOrSelf, action: action)
             navigationItem.leftBarButtonItem?.accessibilityLabel = Localization.close
         }
     }

WooCommerce/Classes/ViewRelated/Dashboard/Stats v4/StoreStatsAndTopPerformersPeriodViewController.swift

@@ -56,7 +56,7 @@ final class StoreStatsAndTopPerformersPeriodViewController: UIViewController {
 
     // MARK: Subviews
 
-    var refreshControl: UIRefreshControl = {
+    lazy var refreshControl: UIRefreshControl = {
         let refreshControl = UIRefreshControl(frame: .zero)
         refreshControl.addTarget(self, action: #selector(pullToRefresh), for: .valueChanged)
         return refreshControl

WooCommerce/Classes/ViewRelated/Products/Edit Product/Downloadable Files/Add or Edit File/ProductDownloadFileViewController.swift

@@ -27,12 +27,11 @@ final class ProductDownloadFileViewController: UIViewController {
         self?.handleKeyboardFrameUpdate(keyboardFrame: keyboardFrame)
     }
 
-    private let updateBarButton: UIBarButtonItem = {
-        let button = UIBarButtonItem(title: nil,
-                                     style: .done,
-                                     target: self,
-                                     action: #selector(completeUpdating))
-        return button
+    private lazy var updateBarButton: UIBarButtonItem = {
+        UIBarButtonItem(title: nil,
+                        style: .done,
+                        target: self,
+                        action: #selector(completeUpdating))
     }()
 
     /// Init

WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/SegmentedView.swift

@@ -24,7 +24,7 @@ struct SegmentedView<Content: View>: View {
 
     var body: some View {
         HStack(spacing: 0) {
-            ForEach(0..<views.count) { (index) in
+            ForEach(0..<views.count, id: \.self) { (index) in
                 VStack(spacing: 0) {
                     getContentView(index)
                     if index == selection {