Merge pull request #5941 from woocommerce/issue/5933-live-stripe-in-test

[Mobile Payments] [Stripe Backend] Prompt merchant to take live account sites out of test mode for IPP

Author: allendav

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/CardPresentPaymentsOnboardingUseCase.swift

@@ -185,7 +185,7 @@ private extension CardPresentPaymentsOnboardingUseCase {
         }
 
         // Account checks
-        return accountChecks()
+        return accountChecks(plugin: .wcPay)
     }
 
     func stripeGatewayOnlyOnboardingState(plugin: SystemPlugin) -> CardPresentPaymentOnboardingState {
@@ -196,18 +196,18 @@ private extension CardPresentPaymentsOnboardingUseCase {
             return .pluginNotActivated(plugin: .stripe)
         }
 
-        return accountChecks()
+        return accountChecks(plugin: .stripe)
     }
 
-    func accountChecks() -> CardPresentPaymentOnboardingState {
+    func accountChecks(plugin: CardPresentPaymentsPlugins) -> CardPresentPaymentOnboardingState {
         guard let account = getPaymentGatewayAccount() else {
             return .genericError
         }
         guard isPaymentGatewaySetupCompleted(account: account) else {
             return .pluginSetupNotCompleted
         }
         guard !isPluginInTestModeWithLiveStripeAccount(account: account) else {
-            return .pluginInTestModeWithLiveStripeAccount
+            return .pluginInTestModeWithLiveStripeAccount(plugin: plugin)
         }
         guard !isStripeAccountUnderReview(account: account) else {
             return .stripeAccountUnderReview

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/InPersonPaymentsViewController.swift

@@ -37,8 +37,8 @@ struct InPersonPaymentsView: View {
                 InPersonPaymentsPluginNotSupportedVersion(plugin: plugin, onRefresh: viewModel.refresh)
             case .pluginNotActivated(let plugin):
                 InPersonPaymentsPluginNotActivated(plugin: plugin, onRefresh: viewModel.refresh)
-            case .pluginInTestModeWithLiveStripeAccount:
-                InPersonPaymentsLiveSiteInTestMode(onRefresh:
+            case .pluginInTestModeWithLiveStripeAccount(let plugin):
+                InPersonPaymentsLiveSiteInTestMode(plugin: plugin, onRefresh:
                     viewModel.refresh)
             case .pluginSetupNotCompleted:
                 InPersonPaymentsWCPayNotSetup(onRefresh: viewModel.refresh)

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/Onboarding Errors/InPersonPaymentsLiveSiteInTestModeView.swift

@@ -1,14 +1,16 @@
 import SwiftUI
+import Yosemite
 
 struct InPersonPaymentsLiveSiteInTestMode: View {
+    let plugin: CardPresentPaymentsPlugins
     let onRefresh: () -> Void
 
     var body: some View {
         InPersonPaymentsOnboardingError(
-            title: Localization.title,
-            message: Localization.message,
+            title: String(format: Localization.title, plugin.pluginName),
+            message: String(format: Localization.message, plugin.pluginName),
             image: InPersonPaymentsOnboardingError.ImageInfo(
-                image: .wcPayPlugin,
+                image: plugin.image,
                 height: 108.0
             ),
             supportLink: false,
@@ -23,24 +25,24 @@ struct InPersonPaymentsLiveSiteInTestMode: View {
 
 private enum Localization {
     static let title = NSLocalizedString(
-        "WooCommerce Payments is in Test Mode",
-        comment: "Title for the error screen when WooCommerce Payments is in test mode on a live site"
+        "%1$@ is in Test Mode",
+        comment: "Title for the error screen when a card present payments plugin is in test mode on a live site. %1$@ is a placeholder for the plugin name."
     )
 
     static let message = NSLocalizedString(
-        "The WooCommerce Payments extension cannot be in test mode for In-Person Payments. "
+        "The %1$@ extension cannot be in test mode for In-Person Payments. "
             + "Please disable test mode.",
-        comment: "Error message when WooCommerce Payments is in test mode on a live site"
+        comment: "Error message when a card present payments plugin is in test mode on a live site. %1$@ is a placeholder for the plugin name."
     )
 
     static let primaryButton = NSLocalizedString(
         "Refresh After Updating",
-        comment: "Button to reload plugin data after updating the WooCommerce Payments plugin settings"
+        comment: "Button to reload plugin data after updating a card present payments plugin settings"
     )
 }
 
 struct InPersonPaymentsLiveSiteInTestMode_Previews: PreviewProvider {
     static var previews: some View {
-        InPersonPaymentsLiveSiteInTestMode(onRefresh: {})
+        InPersonPaymentsLiveSiteInTestMode(plugin: .wcPay, onRefresh: {})
     }
 }

WooCommerce/WooCommerceTests/ViewRelated/CardPresentPayments/CardPresentPaymentsOnboardingUseCaseTests.swift

@@ -141,7 +141,21 @@ class CardPresentPaymentsOnboardingUseCaseTests: XCTestCase {
         let state = useCase.state
 
         // Then
-        XCTAssertEqual(state, .pluginInTestModeWithLiveStripeAccount)
+        XCTAssertEqual(state, .pluginInTestModeWithLiveStripeAccount(plugin: .wcPay))
+    }
+
+    func test_onboarding_returns_stripe_in_test_mode_with_live_stripe_account_when_live_account_in_test_mode() {
+        // Given
+        setupCountry(country: .us)
+        setupStripePlugin(status: .active, version: StripePluginVersion.minimumSupportedVersion)
+        setupPaymentGatewayAccount(status: .complete, isLive: true, isInTestMode: true)
+
+        // When
+        let useCase = CardPresentPaymentsOnboardingUseCase(storageManager: storageManager, stores: stores)
+        let state = useCase.state
+
+        // Then
+        XCTAssertEqual(state, .pluginInTestModeWithLiveStripeAccount(plugin: .stripe))
     }
 
     func test_onboarding_returns_wcpay_unsupported_version_when_patched_wcpay_plugin_outdated() {

Yosemite/Yosemite/Model/Enums/CardPresentPaymentsOnboardingState.swift

@@ -32,10 +32,10 @@ public enum CardPresentPaymentOnboardingState: Equatable {
     ///
     case pluginSetupNotCompleted
 
-    /// This is a bit special case: WCPay is set to "dev mode" but the connected Stripe account is in live mode.
+    /// This is a bit special case: The plugin is set to test mode but the connected Stripe account is a real (live) account.
     /// Connecting to a reader or accepting payments is not supported in this state.
     ///
-    case pluginInTestModeWithLiveStripeAccount
+    case pluginInTestModeWithLiveStripeAccount(plugin: CardPresentPaymentsPlugins)
 
     /// The connected Stripe account has not been reviewed by Stripe yet. This is a temporary state and the user needs to wait.
     ///