Skip to content

Commit 2b21b55

Browse files
committed
Simplify variations flag check by reusing isActionable row property
1 parent a93a011 commit 2b21b55

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductFormViewController.swift

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -339,12 +339,9 @@ final class ProductFormViewController<ViewModel: ProductFormViewModelProtocol>:
339339
ServiceLocator.analytics.track(.productDetailViewGroupedProductsTapped)
340340
editGroupedProducts()
341341
break
342-
case .variations:
342+
case .variations(let row):
343343
ServiceLocator.analytics.track(.productDetailViewVariationsTapped)
344-
guard let product = product as? EditableProductModel else {
345-
return
346-
}
347-
guard product.product.variations.isNotEmpty || isAddProductVariationsEnabled else {
344+
guard let product = product as? EditableProductModel, row.isActionable else {
348345
return
349346
}
350347
let variationsViewController = ProductVariationsViewController(product: product.product,

0 commit comments

Comments
 (0)