Use allCases to return non-nil manuals

Author: iamgabrielma

Hardware/Hardware/CardReader/CardReaderType.swift

@@ -1,6 +1,6 @@
 /// Card reader type. Indicates if a reader is meant to be used
 /// handheld or as a countertop device
-public enum CardReaderType {
+public enum CardReaderType: CaseIterable {
     /// Chipper
     case chipper
     /// Stripe M2

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/CardReaderManualsViewModel.swift

@@ -13,6 +13,6 @@ final class CardReaderManualsViewModel {
 
     init() {
         // Display all card readers at all times. Ref: pdfdoF-1aF-p2
-        self.manuals = CardReaderType.allSupportedReaders.map { $0.manual }
+        self.manuals = CardReaderType.allCases.compactMap { $0.manual }
     }
 }

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/CardReaderType+Manual.swift

@@ -2,9 +2,7 @@ import Foundation
 import Yosemite
 
 extension CardReaderType {
-    static let allSupportedReaders: [CardReaderType] = [CardReaderType.chipper, CardReaderType.stripeM2, CardReaderType.wisepad3]
-
-    var manual: Manual {
+    var manual: Manual? {
         switch self {
         case .chipper:
             return Manual(
@@ -28,7 +26,7 @@ extension CardReaderType {
                 urlString: "https://stripe.com/files/docs/terminal/wp3_product_sheet.pdf"
             )
         case .other:
-            return Manual(id: 5, image: .cardReaderManualIcon, name: "", urlString: "")
+            return nil
         }
     }
 }