Shipping Labels: Filter virtual products from the default shipment (#16127)

Author: itsmeichigo

Modules/Sources/Yosemite/Model/Storage/Order+ReadOnlyConvertible.swift

@@ -82,7 +82,6 @@ extension Storage.Order: ReadOnlyConvertible {
         let orderCustomFields = customFields?.map { $0.toReadOnly() } ?? [Yosemite.MetaData]()
         let orderGiftCards = appliedGiftCards?.map { $0.toReadOnly() } ?? [Yosemite.OrderGiftCard]()
         let orderShippingLabels = shippingLabels?.map { $0.toReadOnly() } ?? [Yosemite.ShippingLabel]()
-        let orderShipments = shipments?.map { $0.toReadOnly() } ?? [Yosemite.WooShippingShipment]()
 
         return Order(siteID: siteID,
                      orderID: orderID,

RELEASE-NOTES.txt

@@ -3,6 +3,7 @@
 
 23.3
 -----
+- [*] Order details: Display only physical items in the Shipping Labels section. [https://github.com/woocommerce/woocommerce-ios/pull/16127]
 - [internal] Address deprecated view modifiers usage following iOS17 API updates [https://github.com/woocommerce/woocommerce-ios/pull/16080]
 
 23.2

WooCommerce/Classes/ViewModels/Order Details/OrderDetailsDataSource.swift

@@ -1241,13 +1241,18 @@ extension OrderDetailsDataSource {
                 siteID: order.siteID,
                 orderID: order.orderID,
                 index: "0",
-                items: order.items.map { item in
-                    var subItems: [String] = []
-                    for index in 0..<item.quantity.intValue {
-                        subItems.append("\(item.itemID)-sub-\(index)")
+                items: order.items
+                    .filter { item in
+                        let matchingProduct = products.first(where: { $0.productID == item.productOrVariationID })
+                        return matchingProduct?.virtual == false
                     }
-                    return WooShippingShipmentItem(id: item.itemID, subItems: subItems)
-                },
+                    .map { item in
+                        var subItems: [String] = []
+                        for index in 0..<item.quantity.intValue {
+                            subItems.append("\(item.itemID)-sub-\(index)")
+                        }
+                        return WooShippingShipmentItem(id: item.itemID, subItems: subItems)
+                    },
                 shippingLabel: nil
             )]
         }()