Skip to content

Commit 3a63cab

Browse files
committed
Update TODO comment where cancelRefund completion is not invoked after failure.
1 parent f9769a7 commit 3a63cab

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Hardware/Hardware/CardReader/StripeCardReader/StripeCardReaderService.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -563,7 +563,7 @@ extension StripeCardReaderService {
563563
}
564564
promise(.success(()))
565565
})
566-
//TODO: handle timeout?
566+
//TODO: 5983 - handle timeout when called from retry after refund failure
567567
}.eraseToAnyPublisher()
568568
}
569569
}

WooCommerce/Classes/ViewModels/CardPresentPayments/CardPresentRefundOrchestrator.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ final class CardPresentRefundOrchestrator {
5959
/// Cancels the current refund.
6060
/// - Parameter onCompletion: called when the cancellation completes.
6161
func cancelRefund(onCompletion: @escaping (Result<Void, Error>) -> Void) {
62-
let action = CardPresentPaymentAction.cancelRefund() { [weak self] result in
62+
let action = CardPresentPaymentAction.cancelRefund { [weak self] result in
6363
self?.allowPassPresentation()
6464
onCompletion(result)
6565
}

WooCommerce/Classes/ViewRelated/Orders/Refund/RefundSubmissionUseCase.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ private extension RefundSubmissionUseCase {
252252
/// Logs the failure reason, cancels the current refund, and offers retry if possible.
253253
func handleRefundFailureAndRetryRefund(_ error: Error, refundAmount: Decimal, charge: WCPayCharge, onCompletion: @escaping (Result<Void, Error>) -> ()) {
254254
// TODO: 5984 - tracks in-person refund error
255-
DDLogError("Failed to collect payment: \(error.localizedDescription)")
255+
DDLogError("Failed to refund: \(error.localizedDescription)")
256256
// Informs about the error.
257257
alerts?.error(error: error) { [weak self] in
258258
// Cancels current payment.

0 commit comments

Comments
 (0)