Skip to content

Commit 43dc075

Browse files
Remove unnecessary discardableResults from SingleOrderScreen
`discardableResult` is unnecessary when we have a returned result which we expect to use. Where we `return self`, the result `self` isn’t used directly, but staying on the screen allows us to chain methods. So `discardableResult` is used to suppress the warning. Co-Authored-By: Evgeny Aleksandrov <[email protected]>
1 parent 7e10e46 commit 43dc075

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

WooCommerce/UITestsFoundation/Screens/Orders/SingleOrderScreen.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ public final class SingleOrderScreen: ScreenObject {
5858
return self
5959
}
6060

61-
@discardableResult
6261
public func tapCollectPaymentButton() throws -> PaymentMethodsScreen {
6362
let orderDetailTableView = app.tables["order-details-table-view"]
6463
while !collectPaymentButton.isFullyVisibleOnScreen() {
@@ -68,7 +67,6 @@ public final class SingleOrderScreen: ScreenObject {
6867
return try PaymentMethodsScreen()
6968
}
7069

71-
@discardableResult
7270
public func goBackToOrdersScreen() throws -> OrdersScreen {
7371
// Only needed for iPhone because iPad shows both Orders and Single Order screens on the same view
7472
if XCUIDevice.isPhone {
@@ -77,7 +75,6 @@ public final class SingleOrderScreen: ScreenObject {
7775
return try OrdersScreen()
7876
}
7977

80-
@discardableResult
8178
public func tapEditOrderButton() throws -> UnifiedOrderScreen {
8279
editOrderButton.tap()
8380
return try UnifiedOrderScreen(flow: .editing)

0 commit comments

Comments
 (0)