Merge pull request #5825 from woocommerce/fix/3821-orders-tab-placeholder-showing-sample-data

Orders tab: fix sample data shown in placeholder view after switching tabs

Author: jaclync

WooCommerce/Classes/ViewRelated/Orders/OrderListViewController.swift

@@ -158,6 +158,8 @@ final class OrderListViewController: UIViewController {
         //
         // We can remove this once we've replaced XLPagerTabStrip.
         tableView.reloadData()
+
+        restartPlaceholderAnimation()
     }
 
     /// Returns a function that creates cells for `dataSource`.
@@ -410,7 +412,7 @@ private extension OrderListViewController {
         // let's reset the state before using it again
         ghostableTableView.removeGhostContent()
         ghostableTableView.displayGhostContent(options: options,
-                                               style: .wooDefaultGhostStyle)
+                                               style: Constants.ghostStyle)
         ghostableTableView.startGhostAnimation()
         ghostableTableView.isHidden = false
     }
@@ -423,6 +425,14 @@ private extension OrderListViewController {
         ghostableTableView.removeGhostContent()
     }
 
+    /// After returning to the screen, `restartGhostAnimation` is required to resume ghost animation.
+    func restartPlaceholderAnimation() {
+        guard ghostableTableView.isHidden == false else {
+            return
+        }
+        ghostableTableView.restartGhostAnimation(style: Constants.ghostStyle)
+    }
+
     /// Shows the EmptyStateViewController
     ///
     func displayEmptyViewController() {
@@ -675,4 +685,8 @@ private extension OrderListViewController {
         case results
         case empty
     }
+
+    enum Constants {
+        static let ghostStyle: GhostStyle = .wooDefaultGhostStyle
+    }
 }