Skip to content

Commit 478ff3e

Browse files
committed
PublishTests: Remove XCTSkipIf for now
Our CircleCI is not on Xcode 11.4 yet so these declarations will fail.
1 parent e18e5ba commit 478ff3e

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

WooCommerce/WooCommerceTests/Tools/Observables/PublishSubjectTests.swift

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,8 @@ final class PublishSubjectTests: XCTestCase {
115115

116116
// MARK: - Proof of Compatibility with Combine's PassthroughSubject
117117

118-
func testCombinePassthroughSubjectEmitsValuesToAnObserver() throws {
118+
func testCombinePassthroughSubjectEmitsValuesToAnObserver() {
119119
guard #available(iOS 13.0, *) else {
120-
try XCTSkipIf(true, "This test is for iOS 13.0+ only")
121120
return
122121
}
123122

@@ -139,9 +138,8 @@ final class PublishSubjectTests: XCTestCase {
139138
XCTAssertEqual(emittedValues, ["dicta"])
140139
}
141140

142-
func testCombinePassthroughSubjectContinuouslyEmitsValuesToAnObserver() throws {
141+
func testCombinePassthroughSubjectContinuouslyEmitsValuesToAnObserver() {
143142
guard #available(iOS 13.0, *) else {
144-
try XCTSkipIf(true, "This test is for iOS 13.0+ only")
145143
return
146144
}
147145

@@ -165,9 +163,8 @@ final class PublishSubjectTests: XCTestCase {
165163
XCTAssertEqual(emittedValues, ["dicta", "amet", "dolor"])
166164
}
167165

168-
func testCombinePassthroughSubjectDoesNotEmitValuesBeforeTheSubscription() throws {
166+
func testCombinePassthroughSubjectDoesNotEmitValuesBeforeTheSubscription() {
169167
guard #available(iOS 13.0, *) else {
170-
try XCTSkipIf(true, "This test is for iOS 13.0+ only")
171168
return
172169
}
173170

@@ -196,9 +193,8 @@ final class PublishSubjectTests: XCTestCase {
196193
XCTAssertEqual(emittedValues, ["dolor"])
197194
}
198195

199-
func testCombinePassthroughSubjectEmitsValuesToAllObservers() throws {
196+
func testCombinePassthroughSubjectEmitsValuesToAllObservers() {
200197
guard #available(iOS 13.0, *) else {
201-
try XCTSkipIf(true, "This test is for iOS 13.0+ only")
202198
return
203199
}
204200

@@ -231,9 +227,8 @@ final class PublishSubjectTests: XCTestCase {
231227
XCTAssertEqual(emittedValues, ["dicta", "dicta", "amet", "amet"])
232228
}
233229

234-
func testCombinePassthroughSubjectDoesNotEmitValuesToCancelledObservers() throws {
230+
func testCombinePassthroughSubjectDoesNotEmitValuesToCancelledObservers() {
235231
guard #available(iOS 13.0, *) else {
236-
try XCTSkipIf(true, "This test is for iOS 13.0+ only")
237232
return
238233
}
239234

0 commit comments

Comments
 (0)