Remove couponDeletion feature flag

Author: iamgabrielma

Experiments/Experiments/DefaultFeatureFlagService.swift

@@ -15,8 +15,6 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
             return buildConfig == .localDeveloper || buildConfig == .alpha
         case .splitViewInOrdersTab:
             return buildConfig == .localDeveloper || buildConfig == .alpha
-        case .couponDeletion:
-            return true
         case .updateOrderOptimistically:
             return buildConfig == .localDeveloper || buildConfig == .alpha
         case .shippingLabelsOnboardingM1:

Experiments/Experiments/FeatureFlag.swift

@@ -30,10 +30,6 @@ public enum FeatureFlag: Int {
     ///
     case splitViewInOrdersTab
 
-    /// Displays the option to delete coupons
-    ///
-    case couponDeletion
-
     /// Enable optimistic updates for orders
     ///
     case updateOrderOptimistically

WooCommerce/Classes/ViewRelated/Coupons/CouponDetails/CouponDetails.swift

@@ -86,12 +86,11 @@ struct CouponDetails: View {
             ])
         }
 
-        if viewModel.isDeletingEnabled {
-            buttons.append(.destructive(Text(Localization.deleteCoupon), action: {
-                ServiceLocator.analytics.track(.couponDetails, withProperties: ["action": "tapped_delete"])
-                showingDeletionConfirmAlert = true
-            }))
-        }
+        buttons.append(.destructive(Text(Localization.deleteCoupon), action: {
+            ServiceLocator.analytics.track(.couponDetails, withProperties: ["action": "tapped_delete"])
+            showingDeletionConfirmAlert = true
+        }))
+
 
         buttons.append(.cancel())
 

WooCommerce/Classes/ViewRelated/Coupons/CouponDetails/CouponDetailsViewModel.swift

@@ -128,7 +128,6 @@ final class CouponDetailsViewModel: ObservableObject {
     private let currencySettings: CurrencySettings
 
     let isEditingEnabled: Bool
-    let isDeletingEnabled: Bool
 
     // Closure to be triggered when the coupon is updated successfully
     let onUpdate: () -> Void
@@ -150,7 +149,6 @@ final class CouponDetailsViewModel: ObservableObject {
         self.onUpdate = onUpdate
 
         isEditingEnabled = coupon.discountType != .other
-        isDeletingEnabled = featureFlags.isFeatureFlagEnabled(.couponDeletion)
         populateDetails()
     }