Break a reference cycle between POSAggregateModel and CardPresentPaymentsOnboardingViewModel

Author: staskus

WooCommerce/Classes/POS/Presentation/PointOfSaleDashboardView.swift

@@ -133,8 +133,8 @@ private extension PointOfSaleDashboardView {
     }
 
     func paymentsOnboardingView(from onboardingViewModel: CardPresentPaymentsOnboardingViewModel) -> some View {
-        onboardingViewModel.showSupport = {
-            posModel.cancelCardPaymentsOnboarding()
+        onboardingViewModel.showSupport = { [weak posModel] in
+            posModel?.cancelCardPaymentsOnboarding()
             showSupport = true
         }
         return PointOfSaleCardPresentPaymentOnboardingView(viewModel: .init(onboardingViewModel: onboardingViewModel,
@@ -144,9 +144,6 @@ private extension PointOfSaleDashboardView {
         .onAppear {
             posModel.trackCardPaymentsOnboardingShown()
         }
-        .onDisappear {
-            onboardingViewModel.showSupport = nil
-        }
     }
 }