Skip to content

Commit 4c49635

Browse files
committed
CardReaderConnectionStatusView: remove unnecessary extra HStack and decrease spacing between border and content for disconnected state, update circle dimension to match design.
1 parent 7edc30b commit 4c49635

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

WooCommerce/Classes/POS/Presentation/CardReaderConnection/CardReaderConnectionStatusView.swift

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,12 @@ struct CardReaderConnectionStatusView: View {
4343
Button {
4444
posModel.connectCardReader()
4545
} label: {
46-
HStack(spacing: Constants.horizontalPadding) {
47-
HStack(spacing: Constants.buttonImageAndTextSpacing) {
48-
circleIcon(with: Color.posAlert)
49-
Text(Localization.readerDisconnected)
50-
.foregroundColor(disconnectedFontColor)
51-
}
46+
HStack(spacing: Constants.buttonImageAndTextSpacing) {
47+
circleIcon(with: Color.posAlert)
48+
Text(Localization.readerDisconnected)
49+
.foregroundColor(disconnectedFontColor)
5250
}
53-
.padding(.horizontal, Constants.horizontalPadding)
51+
.padding(.horizontal, Constants.disconnectedBorderAndContentSpacing)
5452
.frame(maxHeight: .infinity)
5553
.overlay(
5654
RoundedRectangle(cornerRadius: Constants.disconnectedBorderCornerRadius)
@@ -117,11 +115,12 @@ private extension CardReaderConnectionStatusView {
117115
private extension CardReaderConnectionStatusView {
118116
enum Constants {
119117
static let buttonImageAndTextSpacing: CGFloat = 16
120-
static let imageDimension: CGFloat = 12
118+
static let imageDimension: CGFloat = 14
121119
static let progressIndicatorDimension: CGFloat = 10
122120
static let progressIndicatorLineWidth: CGFloat = 2
123121
static let font = POSFontStyle.posBodyMediumRegular()
124122
static let horizontalPadding: CGFloat = 24
123+
static let disconnectedBorderAndContentSpacing: CGFloat = 16
125124
static let disconnectedBorderCornerRadius: CGFloat = 4
126125
static let disconnectedBorderWidth: CGFloat = 2
127126
static let disconnectedBorderInset: CGFloat = 8

0 commit comments

Comments
 (0)