Merge pull request #6634 from woocommerce/issue/6595-settings-button-label

rachelmcr · web-flow · commit 4d33c0f1143d · 2022-04-14T10:38:53.000+01:00
Hub Menu: Add accessibility label to Settings button
diff --git a/WooCommerce/Classes/ViewRelated/Hub Menu/HubMenu.swift b/WooCommerce/Classes/ViewRelated/Hub Menu/HubMenu.swift
@@ -178,6 +178,7 @@ struct HubMenu: View {
                             }
                         }
                     }
+                    .accessibilityLabel(Localization.settings)
                     .accessibilityIdentifier("dashboard-settings-button")
                     Spacer()
                 }
@@ -206,6 +207,7 @@ struct HubMenu: View {
     private enum Localization {
         static let switchStore = NSLocalizedString("Switch store",
                                                    comment: "Switch store option in the hub menu")
+        static let settings = NSLocalizedString("Settings", comment: "Settings button in the hub menu")
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -178,6 +178,7 @@ struct HubMenu: View {`
`178`	`178`	`}`
`179`	`179`	`}`
`180`	`180`	`}`
	`181`	`+ .accessibilityLabel(Localization.settings)`
`181`	`182`	`.accessibilityIdentifier("dashboard-settings-button")`
`182`	`183`	`Spacer()`
`183`	`184`	`}`
`@@ -206,6 +207,7 @@ struct HubMenu: View {`
`206`	`207`	`private enum Localization {`
`207`	`208`	`static let switchStore = NSLocalizedString("Switch store",`
`208`	`209`	`comment: "Switch store option in the hub menu")`
	`210`	`+ static let settings = NSLocalizedString("Settings", comment: "Settings button in the hub menu")`
`209`	`211`	`}`
`210`	`212`	`}`
`211`	`213`