Add new state refreshing for coupon list

Author: itsmeichigo

WooCommerce/Classes/ViewRelated/Coupons/CouponListViewController.swift

@@ -41,15 +41,16 @@ final class CouponListViewController: UIViewController {
             .removeDuplicates()
             .sink { [weak self] state in
                 guard let self = self else { return }
-                self.removeNoResultsOverlay()
-                self.removePlaceholderCoupons()
+                self.resetViews()
                 switch state {
                 case .empty:
                     self.displayNoResultsOverlay()
                 case .loading:
                     self.displayPlaceholderCoupons()
                 case .coupons:
                     self.tableView.reloadData()
+                case .refreshing:
+                    self.refreshControl.beginRefreshing()
                 case .initialized:
                     break
                 }
@@ -63,9 +64,21 @@ final class CouponListViewController: UIViewController {
 
 // MARK: - Actions
 private extension CouponListViewController {
+    /// Triggers a refresh for the coupon list
+    ///
     @objc func refreshCouponList() {
         viewModel.refreshCoupons()
     }
+
+    /// Removes overlays and loading indicators if present.
+    ///
+    func resetViews() {
+        removeNoResultsOverlay()
+        removePlaceholderCoupons()
+        if refreshControl.isRefreshing {
+            refreshControl.endRefreshing()
+        }
+    }
 }
 
 

WooCommerce/Classes/ViewRelated/Coupons/CouponManagementListViewModel.swift

@@ -15,6 +15,7 @@ enum CouponListState {
     case loading // View should show ghost cells
     case empty // View should display the empty state
     case coupons // View should display the contents of `couponViewModels`
+    case refreshing // View should display the refresh control
 }
 
 final class CouponListViewModel {
@@ -139,7 +140,7 @@ extension CouponListViewModel: SyncingCoordinatorDelegate {
               pageSize: Int,
               reason: String?,
               onCompletion: ((Bool) -> Void)?) {
-        transitionToSyncingState(pageNumber: pageNumber)
+        transitionToSyncingState(pageNumber: pageNumber, hasData: couponViewModels.isNotEmpty)
         let action = CouponAction
             .synchronizeCoupons(siteID: siteID,
                                 pageNumber: pageNumber,
@@ -168,9 +169,9 @@ extension CouponListViewModel: SyncingCoordinatorDelegate {
 // MARK: - Pagination
 //
 private extension CouponListViewModel {
-    func transitionToSyncingState(pageNumber: Int) {
+    func transitionToSyncingState(pageNumber: Int, hasData: Bool) {
         if pageNumber == 1 {
-            state = .loading
+            state = hasData ? .refreshing : .loading
         }
     }