update usage of traitCollectionDidChange

Author: iamgabrielma

WooCommerce/Classes/Authentication/Navigation Exceptions/RoleErrorViewController.swift

@@ -61,6 +61,7 @@ class RoleErrorViewController: UIViewController {
         super.viewDidLoad()
 
         configureViews()
+        observeTraitChanges()
     }
 
     override func viewWillAppear(_ animated: Bool) {
@@ -95,6 +96,19 @@ class RoleErrorViewController: UIViewController {
         configureLinkButton()
         configurePrimaryActionButton()
         configureSecondaryActionButton()
+
+        // Set initial image visibility based on vertical size class
+        imageView.isHidden = traitCollection.verticalSizeClass == .compact
+    }
+
+    private func observeTraitChanges() {
+        registerForTraitChanges([UITraitVerticalSizeClass.self, UITraitUserInterfaceStyle.self]) { (self: Self, _) in
+            // Hide image in compact height sizes (e.g. landscape iPhones)
+            // With limited space, text description should have higher priority
+            self.imageView.isHidden = self.traitCollection.verticalSizeClass == .compact
+
+            self.updateViewAppearances()
+        }
     }
 
     func configureDescriptionLabel() {
@@ -128,24 +142,9 @@ class RoleErrorViewController: UIViewController {
         }
     }
 
-    // MARK: Trait Change Adjustments
-
-    override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
-        super.traitCollectionDidChange(previousTraitCollection)
-
-        // hide image in compact height sizes (e.g. landscape iphones).
-        // with limited space, text description should have higher priority.
-        imageView.isHidden = traitCollection.verticalSizeClass == .compact
-
-        // handle dynamic color appearance changes.
-        if let previousTrait = previousTraitCollection,
-           previousTrait.hasDifferentColorAppearance(comparedTo: traitCollection) {
-            updateViewAppearances()
-        }
-    }
 
     /// update views that can adjust to color appearance changes.
-    /// this method is called when color appearance changes are detected in `traitCollectionDidChange`.
+    /// this method is called when color appearance changes are detected via trait change registration.
     private func updateViewAppearances() {
         // illustrations
         imageView.image = viewModel.image

WooCommerce/Classes/Authentication/Navigation Exceptions/ULAccountMismatchViewController.swift

@@ -62,13 +62,15 @@ final class ULAccountMismatchViewController: UIViewController {
         configureSecondaryButon()
 
         setUnifiedMargins(forWidth: view.frame.width)
+        observeTraitChanges()
 
         viewModel.viewDidLoad(self)
     }
 
-    override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
-        super.traitCollectionDidChange(previousTraitCollection)
-        setUnifiedMargins(forWidth: view.frame.width)
+    private func observeTraitChanges() {
+        registerForTraitChanges([UITraitHorizontalSizeClass.self, UITraitVerticalSizeClass.self]) { (self: Self, _) in
+            self.setUnifiedMargins(forWidth: self.view.frame.width)
+        }
     }
 
     override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {

WooCommerce/Classes/Authentication/Navigation Exceptions/ULErrorViewController.swift

@@ -72,6 +72,7 @@ final class ULErrorViewController: UIViewController {
         configureButtonLabels()
 
         setUnifiedMargins(forWidth: view.frame.width)
+        observeTraitChanges()
 
         viewModel.viewDidLoad(self)
     }
@@ -81,9 +82,10 @@ final class ULErrorViewController: UIViewController {
         viewDidAppearSubject.send()
     }
 
-    override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
-        super.traitCollectionDidChange(previousTraitCollection)
-        setUnifiedMargins(forWidth: view.frame.width)
+    private func observeTraitChanges() {
+        registerForTraitChanges([UITraitHorizontalSizeClass.self, UITraitVerticalSizeClass.self]) { (self: Self, _) in
+            self.setUnifiedMargins(forWidth: self.view.frame.width)
+        }
     }
 
     override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {

WooCommerce/Classes/ViewRelated/FilterTabBar/FilterTabBar.swift

@@ -518,23 +518,23 @@ private class TabBarButton: UIButton {
         super.init(frame: frame)
 
         setFont()
+        observeTraitChanges()
     }
 
     required init?(coder: NSCoder) {
         super.init(coder: coder)
 
         setFont()
+        observeTraitChanges()
     }
 
     private func setFont() {
         titleLabel?.applySubheadlineStyle()
     }
 
-    override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
-        super.traitCollectionDidChange(previousTraitCollection)
-
-        if previousTraitCollection?.preferredContentSizeCategory != traitCollection.preferredContentSizeCategory {
-            setFont()
+    private func observeTraitChanges() {
+        registerForTraitChanges([UITraitPreferredContentSizeCategory.self]) { (self: Self, _) in
+            self.setFont()
         }
     }
 }

WooCommerce/Classes/ViewRelated/MainTabBarController.swift

@@ -231,6 +231,13 @@ final class MainTabBarController: UITabBarController {
         startListeningToHubMenuTabBadgeUpdates()
 
         fixTabBarTraitCollectionOnIpadForiOS18()
+        observeTraitChanges()
+    }
+
+    private func observeTraitChanges() {
+        registerForTraitChanges([UITraitHorizontalSizeClass.self, UITraitVerticalSizeClass.self]) { (self: Self, _) in
+            self.fixTabBarTraitCollectionOnIpadForiOS18()
+        }
     }
 
     override func viewWillAppear(_ animated: Bool) {
@@ -310,12 +317,6 @@ final class MainTabBarController: UITabBarController {
 
     // MARK: - iPadOS 18 tabs support
 
-    override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
-         super.traitCollectionDidChange(previousTraitCollection)
-         fixTabBarTraitCollectionOnIpadForiOS18()
-     }
-
-
     /// Force a previous bottom tab bar design on iPadOS 18 when built with Xcode 16
     ///
     /// Override a trait collection for the tab bar controller to be compact to show the same tab layout as on iPhone

WooCommerce/Classes/ViewRelated/Survey/SurveySubmittedViewController.swift

@@ -67,6 +67,13 @@ final class SurveySubmittedViewController: UIViewController, SurveySubmittedView
         applyStyleToComponents()
         applyLocalizedTextsToComponents()
         configureStackViewsAxis()
+        observeTraitChanges()
+    }
+
+    private func observeTraitChanges() {
+        registerForTraitChanges([UITraitPreferredContentSizeCategory.self]) { (self: Self, _) in
+            self.configureStackViewsAxis()
+        }
     }
 
     @IBAction private func contactUsButtonTapped(_ sender: Any) {
@@ -118,15 +125,6 @@ private extension SurveySubmittedViewController {
     }
 }
 
-// MARK: Accessibility handling
-//
-extension SurveySubmittedViewController {
-    override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
-        super.traitCollectionDidChange(previousTraitCollection)
-        configureStackViewsAxis()
-    }
-}
-
 // MARK: Constants
 //
 private extension SurveySubmittedViewController {

WooCommerce/Classes/ViewRelated/Top Banner/TopBannerView.swift

@@ -74,6 +74,13 @@ final class TopBannerView: UIView {
         actionButtons = viewModel.actionButtons.map { _ in UIButton() }
         super.init(frame: .zero)
         configureSubviews(with: viewModel)
+        observeTraitChanges()
+    }
+
+    private func observeTraitChanges() {
+        registerForTraitChanges([UITraitPreferredContentSizeCategory.self]) { (self: Self, _) in
+            self.updateStackViewsAxis()
+        }
     }
 
     required init?(coder aDecoder: NSCoder) {
@@ -312,15 +319,6 @@ private extension TopBannerView {
     }
 }
 
-// MARK: Accessibility Handling
-//
-extension TopBannerView {
-    override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
-        super.traitCollectionDidChange(previousTraitCollection)
-        updateStackViewsAxis()
-    }
-}
-
 // MARK: UI Updates
 //
 private extension TopBannerView {