Rename makeMoreInfoButtonConfig to non-generic name

shiki · shiki · commit 58b7814c7da4 · 2021-09-15T16:25:31.000-06:00
diff --git a/WooCommerce/Classes/ViewRelated/Fancy Alerts/FancyAlertViewController+UnifiedLogin.swift b/WooCommerce/Classes/ViewRelated/Fancy Alerts/FancyAlertViewController+UnifiedLogin.swift
@@ -7,7 +7,7 @@ extension FancyAlertViewController {
             controller.dismiss(animated: true)
             analytics.track(.loginWhatIsJetpackHelpScreenOkButtonTapped)
         }
-        let moreInfoButton = makeMoreInfoButtonConfig()
+        let moreInfoButton = makeLearnMoreAboutJetpackButtonConfig()
         let config = FancyAlertViewController.Config(titleText: Localization.whatIsJetpack,
                                                      bodyText: Localization.whatIsJetpackLongDescription,
                                                      headerImage: .whatIsJetpackImage,
@@ -96,7 +96,7 @@ private extension FancyAlertViewController {
         }
     }
 
-    static func makeMoreInfoButtonConfig() -> FancyAlertViewController.Config.ButtonConfig {
+    static func makeLearnMoreAboutJetpackButtonConfig(analytics: Analytics) -> FancyAlertViewController.Config.ButtonConfig {
         return FancyAlertViewController.Config.ButtonConfig(Localization.learnMore) { controller, _ in
             guard let url = URL(string: Strings.whatsJetpackURLString) else {
                 return

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ extension FancyAlertViewController {`
`7`	`7`	`controller.dismiss(animated: true)`
`8`	`8`	`analytics.track(.loginWhatIsJetpackHelpScreenOkButtonTapped)`
`9`	`9`	`}`
`10`		`- let moreInfoButton = makeMoreInfoButtonConfig()`
	`10`	`+ let moreInfoButton = makeLearnMoreAboutJetpackButtonConfig()`
`11`	`11`	`let config = FancyAlertViewController.Config(titleText: Localization.whatIsJetpack,`
`12`	`12`	`bodyText: Localization.whatIsJetpackLongDescription,`
`13`	`13`	`headerImage: .whatIsJetpackImage,`
`@@ -96,7 +96,7 @@ private extension FancyAlertViewController {`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`
`99`		`- static func makeMoreInfoButtonConfig() -> FancyAlertViewController.Config.ButtonConfig {`
	`99`	`+ static func makeLearnMoreAboutJetpackButtonConfig(analytics: Analytics) -> FancyAlertViewController.Config.ButtonConfig {`
`100`	`100`	`return FancyAlertViewController.Config.ButtonConfig(Localization.learnMore) { controller, _ in`
`101`	`101`	`guard let url = URL(string: Strings.whatsJetpackURLString) else {`
`102`	`102`	`return`