Move URL to WooConstants to indicate trust

Author: joshheald

WooCommerce/Classes/System/WooConstants.swift

@@ -154,6 +154,9 @@ extension WooConstants {
 #else
         case couponManagementFeedback = "https://automattic.survey.fm/woo-app-coupon-management-production"
 #endif
+        /// URL for the Enable Cash on Delivery (or Pay in Person) onboarding step's learn more link.
+        /// 
+        case cashOnDeliveryLearnMoreUrl = "https://woocommerce.com/document/stripe/accept-in-person-payments-with-stripe/#section-8"
 
         /// Returns the URL version of the receiver
         ///

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/Onboarding Errors/InPersonPaymentsCashOnDeliveryPaymentGatewayNotSetUpView.swift

@@ -27,7 +27,7 @@ struct InPersonPaymentsCashOnDeliveryPaymentGatewayNotSetUpView: View {
 
             Spacer()
 
-            InPersonPaymentsLearnMore(url: Constants.cashOnDeliveryLearnMoreUrl,
+            InPersonPaymentsLearnMore(url: WooConstants.URLs.cashOnDeliveryLearnMoreUrl.asURL(),
                                       formatText: Localization.cashOnDeliveryLearnMore)
         }
     }
@@ -70,6 +70,4 @@ private enum Localization {
 
 private enum Constants {
     static let imageHeight: CGFloat = 140.0
-    static let cashOnDeliveryLearnMoreUrl = URL(
-        string: "https://woocommerce.com/document/stripe/accept-in-person-payments-with-stripe/#section-8")!
 }

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/Onboarding Errors/InPersonPaymentsCashOnDeliveryPaymentGatewayNotSetUpViewModel.swift

@@ -1,7 +1,7 @@
 import Foundation
 import Yosemite
 
-class InPersonPaymentsCashOnDeliveryPaymentGatewayNotSetUpViewModel: ObservableObject {
+final class InPersonPaymentsCashOnDeliveryPaymentGatewayNotSetUpViewModel: ObservableObject {
     let completion: () -> ()
     private let stores: StoresManager
     private let noticePresenter: NoticePresenter