Remove the stripe feature flag too

Author: allendav

Experiments/Experiments/DefaultFeatureFlagService.swift

@@ -33,8 +33,6 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
             return true
         case .systemStatusReport:
             return true
-        case .stripeExtensionInPersonPayments:
-            return buildConfig == .localDeveloper || buildConfig == .alpha
         case .myStoreTabUpdates:
             return true
         case .couponView:

Experiments/Experiments/FeatureFlag.swift

@@ -66,10 +66,6 @@ public enum FeatureFlag: Int {
     ///
     case systemStatusReport
 
-    /// Allows sites using the WooCommerce Stripe Payment Gateway extension to accept In-Person Payments
-    ///
-    case stripeExtensionInPersonPayments
-
     /// Home Screen project milestone 2: design updates to the My Store tab
     ///
     case myStoreTabUpdates

WooCommerce/Classes/Yosemite/AuthenticatedState.swift

@@ -26,9 +26,6 @@ class AuthenticatedState: StoresManagerState {
         let storageManager = ServiceLocator.storageManager
         let network = AlamofireNetwork(credentials: credentials)
 
-        /// TODO - remove this feature flag related logic when no longer needed
-        let allowStripeIPP = ServiceLocator.featureFlagService.isFeatureFlagEnabled(.stripeExtensionInPersonPayments)
-
         services = [
             AccountStore(dispatcher: dispatcher, storageManager: storageManager, network: network),
             AppSettingsStore(dispatcher: dispatcher, storageManager: storageManager, fileStorage: PListFileStorage()),
@@ -67,8 +64,7 @@ class AuthenticatedState: StoresManagerState {
             CardPresentPaymentStore(dispatcher: dispatcher,
                                     storageManager: storageManager,
                                     network: network,
-                                    cardReaderService: ServiceLocator.cardReaderService,
-                                    allowStripeIPP: allowStripeIPP),
+                                    cardReaderService: ServiceLocator.cardReaderService),
             ReceiptStore(dispatcher: dispatcher,
                          storageManager: storageManager,
                          network: network,

Yosemite/Yosemite/Stores/CardPresentPaymentStore.swift

@@ -17,13 +17,6 @@ public final class CardPresentPaymentStore: Store {
     ///
     private let commonReaderConfigProvider: CommonReaderConfigProvider
 
-    /// Instead of adding a reference to the feature flag service (in the WooCommerce layer),
-    /// and since feature flag values don't mutate, let's just have a private bool passed into this service
-    /// to allow (or not) Stripe IPP.
-    /// TODO: Remove this feature flag when no longer needed.
-    ///
-    private var allowStripeIPP: Bool
-
     /// Which backend is the store using? Default to WCPay until told otherwise
     private var usingBackend: CardPresentPaymentStoreBackend = .wcpay
 
@@ -39,14 +32,12 @@ public final class CardPresentPaymentStore: Store {
         dispatcher: Dispatcher,
         storageManager: StorageManagerType,
         network: Network,
-        cardReaderService: CardReaderService,
-        allowStripeIPP: Bool
+        cardReaderService: CardReaderService
     ) {
         self.cardReaderService = cardReaderService
         self.commonReaderConfigProvider = CommonReaderConfigProvider()
         self.remote = WCPayRemote(network: network)
         self.stripeRemote = StripeRemote(network: network)
-        self.allowStripeIPP = allowStripeIPP
         super.init(dispatcher: dispatcher, storageManager: storageManager, network: network)
     }
 
@@ -365,11 +356,6 @@ private extension CardPresentPaymentStore {
     /// Sets the store to use a given payment gateway
     ///
     func use(paymentGatewayAccount: PaymentGatewayAccount) {
-        guard allowStripeIPP else {
-            DDLogError("useStripeAsBackend called when stripeExtensionInPersonPayments disabled")
-            return
-        }
-
         guard paymentGatewayAccount.isWCPay else {
             usingBackend = .stripe
             return