Refactored BottomSheet disclosureIndicator

Previously the disclosureIndicator had to be shown if you want a selection state on tapping a button in the bottom sheet.

This change extracts the disclosure indicator logic from isActionable

Now the user can see the cell being tap with a selection state despite not having a disclosure indicator.

Not all cells actionable cells display more information so not all need to display a disclosure indicator.

Author: iamgabrielma

WooCommerce/Classes/ViewRelated/Orders/Order Creation/FlowCoordinator/BottomSheetOrderType.swift

@@ -78,7 +78,7 @@ final class OrderTypeBottomSheetListSelectorCommand: BottomSheetListSelectorComm
                                                                     imageTintColor: .gray(.shade20),
                                                                     numberOfLinesForTitle: 0,
                                                                     numberOfLinesForText: 0,
-                                                                    isActionable: false)
+                                                                    isActionable: true)
         cell.updateUI(viewModel: viewModel)
     }
 

WooCommerce/Classes/ViewRelated/Products/Edit Product/Cells/ImageAndTitleAndTextTableViewCell.swift

@@ -68,6 +68,7 @@ final class ImageAndTitleAndTextTableViewCell: UITableViewCell {
         let numberOfLinesForText: Int
         let isActionable: Bool
         let isSelected: Bool
+        let showsDisclosureIndicator: Bool
         let showsSeparator: Bool
 
         init(title: String?,
@@ -80,6 +81,7 @@ final class ImageAndTitleAndTextTableViewCell: UITableViewCell {
              numberOfLinesForText: Int = 1,
              isSelected: Bool = false,
              isActionable: Bool = true,
+             showsDisclosureIndicator: Bool = false,
              showsSeparator: Bool = true) {
             self.title = title
             self.titleFontStyle = titleFontStyle
@@ -91,6 +93,7 @@ final class ImageAndTitleAndTextTableViewCell: UITableViewCell {
             self.numberOfLinesForText = numberOfLinesForText
             self.isSelected = isSelected
             self.isActionable = isActionable
+            self.showsDisclosureIndicator = showsDisclosureIndicator
             self.showsSeparator = showsSeparator
         }
     }
@@ -157,7 +160,7 @@ extension ImageAndTitleAndTextTableViewCell {
         descriptionLabel.numberOfLines = viewModel.numberOfLinesForText
         contentImageView.image = viewModel.image
         contentImageStackView.isHidden = viewModel.image == nil
-        accessoryType = viewModel.isActionable ? .disclosureIndicator : (viewModel.isSelected ? .checkmark : .none)
+        accessoryType = viewModel.showsDisclosureIndicator ? .disclosureIndicator : .none
         selectionStyle = viewModel.isActionable ? .default: .none
         accessoryView = nil
 

WooCommerce/Classes/ViewRelated/Products/Edit Product/Downloadable Files/File List/BottomSheetListSelector/DownloadableFileBottomSheetListSelectorCommand.swift

@@ -26,7 +26,8 @@ final class DownloadableFileBottomSheetListSelectorCommand: BottomSheetListSelec
                                                                     textTintColor: .text,
                                                                     image: model.image,
                                                                     imageTintColor: .gray(.shade20),
-                                                                    numberOfLinesForText: 0)
+                                                                    numberOfLinesForText: 0,
+                                                                    showsDisclosureIndicator: true)
         cell.updateUI(viewModel: viewModel)
     }