OrderDetailsDataSourceTests: Use MockOrders

Author: shiki

WooCommerce/WooCommerceTests/Tools/MockOrders.swift

@@ -4,7 +4,7 @@ final class MockOrders {
     let siteID: Int64 = 1234
     let orderID: Int64 = 5678
 
-    func sampleOrder() -> Order {
+    func makeOrder(items: [OrderItem] = []) -> Order {
         return Order(siteID: siteID,
                      orderID: orderID,
                      parentID: 0,
@@ -23,14 +23,18 @@ final class MockOrders {
                      total: "31.20",
                      totalTax: "1.20",
                      paymentMethodTitle: "Credit Card (Stripe)",
-                     items: [],
+                     items: items,
                      billingAddress: sampleAddress(),
                      shippingAddress: sampleAddress(),
                      shippingLines: sampleShippingLines(),
                      coupons: [],
                      refunds: [])
     }
 
+    func sampleOrder() -> Order {
+        makeOrder()
+    }
+
     func sampleOrderCreatedInCurrentYear() -> Order {
         return Order(siteID: siteID,
                      orderID: orderID,

WooCommerce/WooCommerceTests/ViewRelated/Orders/Order Details/OrderDetailsDataSourceTests.swift

@@ -62,30 +62,7 @@ final class OrderDetailsDataSourceTests: XCTestCase {
 
 private extension OrderDetailsDataSourceTests {
     func makeOrder() -> Order {
-        Order(siteID: 1_000,
-              orderID: 2_000,
-              parentID: 0,
-              customerID: 11,
-              number: "963",
-              statusKey: "processing",
-              currency: "USD",
-              customerNote: "",
-              dateCreated: Date(),
-              dateModified: Date(),
-              datePaid: Date(),
-              discountTotal: "30.00",
-              discountTax: "1.20",
-              shippingTotal: "0.00",
-              shippingTax: "0.00",
-              total: "31.20",
-              totalTax: "1.20",
-              paymentMethodTitle: "Credit Card (Stripe)",
-              items: [makeOrderItem(), makeOrderItem()],
-              billingAddress: nil,
-              shippingAddress: nil,
-              shippingLines: [],
-              coupons: [],
-              refunds: [])
+        MockOrders().makeOrder(items: [makeOrderItem(), makeOrderItem()])
     }
 
     func makeOrderItem() -> OrderItem {