Simplified accessoryType logic. Addressed PR feedback.

Author: iamgabrielma

WooCommerce/Classes/ViewRelated/Coupons/Add and Edit Coupons/DiscountTypeBottomSheetListSelectorCommand.swift

@@ -28,9 +28,8 @@ final class DiscountTypeBottomSheetListSelectorCommand: BottomSheetListSelectorC
                                                                     image: model.actionSheetIcon,
                                                                     imageTintColor: .gray(.shade20),
                                                                     numberOfLinesForText: 0,
-                                                                    isSelected: isSelected(model: model),
-                                                                    isActionable: false,
-                                                                    showsDisclosureIndicator: true)
+                                                                    isSelected: isSelected(model: model)
+        )
         cell.updateUI(viewModel: viewModel)
     }
 

WooCommerce/Classes/ViewRelated/Orders/Order Creation/FlowCoordinator/BottomSheetOrderType.swift

@@ -77,8 +77,7 @@ final class OrderTypeBottomSheetListSelectorCommand: BottomSheetListSelectorComm
                                                                     image: model.actionSheetImage,
                                                                     imageTintColor: .gray(.shade20),
                                                                     numberOfLinesForTitle: 0,
-                                                                    numberOfLinesForText: 0,
-                                                                    isActionable: true)
+                                                                    numberOfLinesForText: 0)
         cell.updateUI(viewModel: viewModel)
     }
 

WooCommerce/Classes/ViewRelated/Products/Edit Product/Cells/ImageAndTitleAndTextTableViewCell.swift

@@ -161,11 +161,11 @@ extension ImageAndTitleAndTextTableViewCell {
         contentImageView.image = viewModel.image
         contentImageStackView.isHidden = viewModel.image == nil
         accessoryType = viewModel.showsDisclosureIndicator ? .disclosureIndicator : .none
-        if viewModel.isActionable && viewModel.showsDisclosureIndicator == false {
-            accessoryType = .none
-        } else if viewModel.isActionable == false && viewModel.showsDisclosureIndicator && viewModel.isSelected {
+        if viewModel.showsDisclosureIndicator {
+            accessoryType = .disclosureIndicator
+        } else if viewModel.isSelected {
             accessoryType = .checkmark
-        } else if viewModel.isActionable == false && viewModel.showsDisclosureIndicator && viewModel.isSelected == false {
+        } else {
             accessoryType = .none
         }
         selectionStyle = viewModel.isActionable ? .default: .none