Skip to content

Commit 5f38e3b

Browse files
authored
Merge pull request #2234 from woocommerce/issue/2232-fix-product-form-more-popover
Edit Products: fix "..." more menu popover appearance
2 parents dddf15b + 82b3d08 commit 5f38e3b

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductFormViewController.swift

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ private extension ProductFormViewController {
323323
let moreButton = UIBarButtonItem(image: .moreImage,
324324
style: .plain,
325325
target: self,
326-
action: #selector(presentMoreOptionsActionSheet))
326+
action: #selector(presentMoreOptionsActionSheet(_:)))
327327
moreButton.accessibilityLabel = NSLocalizedString("More options", comment: "Accessibility label for the Edit Product More Options action sheet")
328328
moreButton.accessibilityIdentifier = "edit-product-more-options-button"
329329
return moreButton
@@ -653,7 +653,7 @@ private extension ProductFormViewController {
653653

654654
/// More Options Action Sheet
655655
///
656-
@objc func presentMoreOptionsActionSheet() {
656+
@objc func presentMoreOptionsActionSheet(_ sender: UIBarButtonItem) {
657657
let actionSheet = UIAlertController(title: nil, message: nil, preferredStyle: .actionSheet)
658658
actionSheet.view.tintColor = .text
659659

@@ -673,8 +673,7 @@ private extension ProductFormViewController {
673673
}
674674

675675
let popoverController = actionSheet.popoverPresentationController
676-
popoverController?.sourceView = view
677-
popoverController?.sourceRect = view.bounds
676+
popoverController?.barButtonItem = sender
678677

679678
present(actionSheet, animated: true)
680679
}

0 commit comments

Comments
 (0)