Merge pull request #5443 from woocommerce/issue/5428-print

[Mobile Payments] Remove print and log to Lumberjack where needed

Author: ctarda

Hardware/Hardware/CardReader/StripeCardReader/StripeCardReaderService.swift

@@ -408,12 +408,12 @@ private extension StripeCardReaderService {
                     /// https://stripe.dev/stripe-terminal-ios/docs/Classes/SCPTerminal.html#/c:objc(cs)SCPTerminal(im)collectPaymentMethod:delegate:completion:
 
                     if underlyingError != .commandCancelled {
-                        print("==== collect payment method was not cancelled. this is an actual error ", underlyingError)
+                        DDLogError("💳 Error: collect payment method \(underlyingError)")
                         promise(.failure(CardReaderServiceError.paymentMethodCollection(underlyingError: underlyingError)))
                     }
 
                     if underlyingError == .commandCancelled {
-                        print("==== collect payment method cancelled. this is an error we ignore ", error)
+                        DDLogWarn("💳 Warning: collect payment error cancelled. We actively ignore this error \(error)")
                     }
 
                 }
@@ -488,12 +488,10 @@ extension StripeCardReaderService: BluetoothReaderDelegate {
     }
 
     public func reader(_ reader: Reader, didStartInstallingUpdate update: ReaderSoftwareUpdate, cancelable: StripeTerminal.Cancelable?) {
-        print("==== started software update")
         softwareUpdateSubject.send(.started(cancelable: cancelable.map(StripeCancelable.init(cancelable:))))
     }
 
     public func reader(_ reader: Reader, didReportReaderSoftwareUpdateProgress progress: Float) {
-        print("==== did repost software update progress ", progress)
         softwareUpdateSubject.send(.installing(progress: progress))
     }
 

Hardware/HardwareTests/AirPrintReceipt/ReceiptRendererTest.swift

@@ -24,8 +24,6 @@ final class ReceiptRendererTest: XCTestCase {
 
         let renderer = ReceiptRenderer(content: content)
 
-        print(renderer.htmlContent())
-
         XCTAssertEqual(
             Insecure.MD5.hash(data: renderer.htmlContent().data(using: .utf8)!).description,
             expectedResultWithHtmlSymbolsMd5Description

WooCommerce/Classes/ViewRelated/CardPresentPayments/CardReaderConnectionController.swift

@@ -411,7 +411,7 @@ private extension CardReaderConnectionController {
                 ServiceLocator.analytics.track(.cardReaderSoftwareUpdateCancelTapped, withProperties: analyticsProperties)
                 cancelable.cancel { result in
                     if case .failure(let error) = result {
-                        print("=== error canceling software update: \(error)")
+                        DDLogError("💳 Error: canceling software update \(error)")
                     } else {
                         ServiceLocator.analytics.track(.cardReaderSoftwareUpdateCanceled, withProperties: analyticsProperties)
                     }

WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/CardReaderSettingsConnectedViewModel.swift

@@ -148,7 +148,7 @@ final class CardReaderSettingsConnectedViewModel: CardReaderSettingsPresentedVie
             self.track(.cardReaderSoftwareUpdateCancelTapped)
             self.softwareUpdateCancelable?.cancel(completion: { [weak self] result in
                 if case .failure(let error) = result {
-                    print("=== error canceling software update: \(error)")
+                    DDLogError("💳 Error: canceling software update \(error)")
                 } else {
                     self?.track(.cardReaderSoftwareUpdateCanceled)
                     self?.completeCardReaderUpdate(success: false)

Yosemite/Yosemite/Stores/ReceiptStore.swift

@@ -199,7 +199,6 @@ private extension ReceiptStore {
 
         do {
             try fileStorage.write(content, to: outputURL)
-            Swift.print("new receipt saved: open \(outputURL.path)") // command to open the generated file
         } catch {
             DDLogError("⛔️ Unable to save receipt for order id: \(order.orderID)")
         }