Update MockPushNotificationsManager

Author: itsmeichigo

RELEASE-NOTES.txt

@@ -6,6 +6,7 @@
 - [*] Better support site credential login for sites with captcha plugins [https://github.com/woocommerce/woocommerce-ios/pull/16372]
 - [*] Crash fix attempt to resolve the race condition in request authenticator swapping [https://github.com/woocommerce/woocommerce-ios/pull/16370]
 - [*] Update products on the Top Performers card when there are changes made to displayed products [https://github.com/woocommerce/woocommerce-ios/pull/16380]
+- [*] Fixed issue unregistering device from push notifications [https://github.com/woocommerce/woocommerce-ios/pull/16386]
 - [Internal] Fix broken navigation to a variable product selector [https://github.com/woocommerce/woocommerce-ios/pull/16363]
 
 23.7

WooCommerce/Classes/ServiceLocator/PushNotesManager.swift

@@ -50,6 +50,7 @@ protocol PushNotesManager {
     func registerForRemoteNotifications()
 
     /// Unregisters the Application from WordPress.com Push Notifications Service.
+    /// - Parameter onCompletion: Closure to be executed on completion.
     ///
     func unregisterForRemoteNotifications(onCompletion: @escaping () -> Void)
 

WooCommerce/Classes/Yosemite/DefaultStoresManager.swift

@@ -299,7 +299,8 @@ class DefaultStoresManager: StoresManager {
 
         // Unregister from remote notifications asynchronously
         pushNotesManager.unregisterForRemoteNotifications {
-            // Release the strong reference to allow state cleanup
+            DDLogInfo("📱 Push notification unregistration completed after logout")
+            // Keep `currentState` until the end of the closure
             _ = currentState
         }
 

WooCommerce/WooCommerceTests/Mocks/MockPushNotificationsManager.swift

@@ -78,7 +78,7 @@ final class MockPushNotificationsManager: PushNotesManager {
 
     }
 
-    func unregisterForRemoteNotifications() {
+    func unregisterForRemoteNotifications(onCompletion: @escaping () -> Void) {
 
     }