Remove Action to get payments page

Author: Ecarrion

Yosemite/Yosemite/Actions/SettingAction.swift

@@ -22,10 +22,6 @@ public enum SettingAction: Action {
     ///
     case retrieveSiteAPI(siteID: Int64, onCompletion: (Result<SiteAPI, Error>) -> Void)
 
-    /// Retrieves the store payments page path.
-    ///
-    case getPaymentsPagePath(siteID: Int64, onCompletion: (Result<String, SettingStore.SettingError>) -> Void)
-
     /// Retrieves the setting for whether coupons are enabled for the specified store
     ///
     case retrieveCouponSetting(siteID: Int64, onCompletion: (Result<Bool, Error>) -> Void)

Yosemite/Yosemite/Stores/SettingStore.swift

@@ -42,8 +42,6 @@ public class SettingStore: Store {
             synchronizeAdvancedSiteSettings(siteID: siteID, onCompletion: onCompletion)
         case .retrieveSiteAPI(let siteID, let onCompletion):
             retrieveSiteAPI(siteID: siteID, onCompletion: onCompletion)
-        case let .getPaymentsPagePath(siteID, onCompletion):
-            getPaymentsPagePath(siteID: siteID, onCompletion: onCompletion)
         case let .retrieveCouponSetting(siteID, onCompletion):
             retrieveCouponSetting(siteID: siteID, onCompletion: onCompletion)
         case let .enableCouponSetting(siteID, onCompletion):
@@ -113,17 +111,6 @@ private extension SettingStore {
         siteAPIRemote.loadAPIInformation(for: siteID, completion: onCompletion)
     }
 
-    /// Retrieves the store payments page path.
-    ///
-    func getPaymentsPagePath(siteID: Int64, onCompletion: @escaping (Result<String, SettingStore.SettingError>) -> Void) {
-        guard let paymentPageSettings = sharedDerivedStorage.loadSiteSetting(siteID: siteID, settingID: SettingKeys.paymentsPage),
-              let paymentPagePath = paymentPageSettings.value else {
-                  return onCompletion(.failure(SettingError.paymentsPageNotFound))
-              }
-
-        onCompletion(.success(paymentPagePath))
-    }
-
     /// Retrieves the setting for whether coupons are enabled for the specified store
     ///
     func retrieveCouponSetting(siteID: Int64, onCompletion: @escaping (Result<Bool, Error>) -> Void) {
@@ -283,18 +270,9 @@ extension SettingStore {
 
 // MARK: Definitions
 extension SettingStore {
-    /// Possible store errors.
-    ///
-    public enum SettingError: Swift.Error {
-        /// Payment page path was not found
-        ///
-        case paymentsPageNotFound
-    }
-
     /// Settings keys.
     ///
     private enum SettingKeys {
-        static let paymentsPage = "woocommerce_checkout_pay_endpoint"
         static let coupons = "woocommerce_enable_coupons"
         static let analytics = "woocommerce_analytics_enabled"
     }

Yosemite/YosemiteTests/Stores/SettingStoreTests.swift

@@ -596,41 +596,6 @@ final class SettingStoreTests: XCTestCase {
         XCTAssertTrue(result.isFailure)
     }
 
-    func test_getPaymentsPagePath_returns_page_when_setting_is_stored() throws {
-        // Given
-        storageManager.insertSampleSiteSetting(readOnlySiteSetting: sampleAdvancedSiteSetting())
-        let store = SettingStore(dispatcher: dispatcher, storageManager: storageManager, network: network)
-
-        // When
-        let result: Result<String, SettingStore.SettingError> = waitFor { promise in
-            let action = SettingAction.getPaymentsPagePath(siteID: self.sampleSiteID) { result in
-                promise(result)
-            }
-            store.onAction(action)
-        }
-
-        // Then
-        let paymentPath = try result.get()
-        XCTAssertEqual(paymentPath, sampleAdvancedSiteSetting().value)
-    }
-
-    func test_getPaymentsPagePath_returns_error_when_setting_is_not_stored() throws {
-        // Given
-        let store = SettingStore(dispatcher: dispatcher, storageManager: storageManager, network: network)
-
-        // When
-        let result: Result<String, SettingStore.SettingError> = waitFor { promise in
-            let action = SettingAction.getPaymentsPagePath(siteID: self.sampleSiteID) { result in
-                promise(result)
-            }
-            store.onAction(action)
-        }
-
-        // Then
-        let error = try XCTUnwrap(result.failure)
-        XCTAssertEqual(error, .paymentsPageNotFound)
-    }
-
     func test_retrieveCouponSetting_returns_correct_setting() throws {
         // Given
         let store = SettingStore(dispatcher: dispatcher, storageManager: storageManager, network: network)