Update CardPresentPaymentsOnboardingUseCase to use "networkActivated" and refresh from SystemStatus too

Author: allendav

Networking/Networking/Mapper/SystemStatusMapper.swift

@@ -21,7 +21,7 @@ struct SystemStatusMapper: Mapper {
 
         /// For now, we're going to override the networkActivated Bool in each plugin to convey active or inactive -- in order to
         /// avoid a core data change to add a Bool for activated
-        /// This will be undone in #xxxx
+        /// This will be undone in #5269
         let activePlugins = systemStatus.activePlugins.map {
             $0.overrideNetworkActivated(isNetworkActivated: true)
         }

Networking/NetworkingTests/Mapper/SystemStatusMapperTests.swift

@@ -22,7 +22,7 @@ class SystemStatusMapperTests: XCTestCase {
         let expectedAuthorName = "Automattic"
         let expectedAuthorUrl = "https://woocommerce.com"
         /// TODO - The mapper is overriding networkActivated to be true for active plugins in general
-        /// When we fix #xxxx this test will need to be updated to properly test the
+        /// When we fix #5269 this test will need to be updated to properly test the
         /// new `activated` attribute that will be added to SystemPlugin instead
         let expectedNetworkActivated = true
 
@@ -58,7 +58,7 @@ class SystemStatusMapperTests: XCTestCase {
         let expectedAuthorName = "Matt Mullenweg"
         let expectedAuthorUrl = "http://ma.tt/"
         /// TODO - The mapper is overriding networkActivated to be true for active plugins in general
-        /// When we fix #xxxx this test will need to be updated to properly test the
+        /// When we fix #5269 this test will need to be updated to properly test the
         /// new `activated` attribute that will be added to SystemPlugin instead
         let expectedNetworkActivated = false
 

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/CardPresentPaymentsOnboardingUseCase.swift

@@ -59,15 +59,15 @@ private extension CardPresentPaymentsOnboardingUseCase {
         stores.dispatch(settingsAction)
 
         // We need to sync plugins to check if WCPay is installed, up to date, and active
-        let sitePluginsAction = SitePluginAction.synchronizeSitePlugins(siteID: siteID) { result in
+        let systemPluginsAction = SystemStatusAction.synchronizeSystemPlugins(siteID: siteID) { result in
             if case let .failure(error) = result {
-                DDLogError("[CardPresentPaymentsOnboarding] Error syncing site plugins: \(error)")
+                DDLogError("[CardPresentPaymentsOnboarding] Error syncing system plugins: \(error)")
                 errors.append(error)
             }
             group.leave()
         }
         group.enter()
-        stores.dispatch(sitePluginsAction)
+        stores.dispatch(systemPluginsAction)
 
         // We need to sync payment gateway accounts to see if WCPay is set up correctly
         let paymentGatewayAccountsAction = PaymentGatewayAccountAction.loadAccounts(siteID: siteID) { result in
@@ -175,8 +175,10 @@ private extension CardPresentPaymentsOnboardingUseCase {
     }
 
     func isWCPayActivated(plugin: SystemPlugin) -> Bool {
-        // TODO hook up active/not if possible (might need to add to entity)
-        return true
+        // For now we are overriding networkActivated in SystemStatusMapper
+        // to convey active / not active for a plugin.
+        // TODO - replace with simply `activated` as part of #5269
+        return plugin.networkActivated
     }
 
     func getWCPayAccount() -> PaymentGatewayAccount? {