5003 A11y labels on edit icons in Order Details

The two icon-only edit buttons (✎) for Shipping Address and Customer Note in the Order Details screen did not have accessibility labels, which meant that VoiceOver would read them as "Button" with no context or information about what the cell accessory button does.

This adds an accessibility label to these two buttons, briefly describing their function.

Author: joshheald

WooCommerce/Classes/ViewModels/Order Details/OrderDetailsDataSource.swift

@@ -382,6 +382,10 @@ private extension OrderDetailsDataSource {
         cell.onEditTapped = { [weak self] in
             self?.onCellAction?(.editCustomerNote, nil)
         }
+
+        cell.editButtonAccessibilityLabel = NSLocalizedString(
+            "Update Note",
+            comment: "Accessibility Label for the edit button to change the Customer Provided Note in Order Details")
     }
 
     private func configureBillingDetail(cell: WooBasicTableViewCell) {
@@ -788,6 +792,10 @@ private extension OrderDetailsDataSource {
         cell.onEditTapped = orderEditingEnabled ? { [weak self] in
             self?.onCellAction?(.editShippingAddress, nil)
         } : nil
+
+        cell.editButtonAccessibilityLabel = NSLocalizedString(
+            "Update Address",
+            comment: "Accessibility Label for the edit button to change the Customer Shipping Address in Order Details")
     }
 
     private func configureShippingMethod(cell: CustomerNoteTableViewCell) {

WooCommerce/Classes/ViewRelated/Orders/Order Details/Customer Section/CustomerInfoTableViewCell.swift

@@ -56,6 +56,17 @@ class CustomerInfoTableViewCell: UITableViewCell {
         }
     }
 
+    /// Accessibility label to be used on the edit button, when shown
+    ///
+    var editButtonAccessibilityLabel: String? {
+        get {
+            editButton.accessibilityLabel
+        }
+        set {
+            editButton.accessibilityLabel = newValue
+        }
+    }
+
     override func awakeFromNib() {
         super.awakeFromNib()
 
@@ -69,6 +80,7 @@ class CustomerInfoTableViewCell: UITableViewCell {
         nameLabel.text = nil
         addressLabel.text = nil
         onEditTapped = nil
+        editButton.accessibilityLabel = nil
     }
 }
 

WooCommerce/Classes/ViewRelated/Orders/Order Details/Customer Section/CustomerNoteTableViewCell.swift

@@ -43,6 +43,17 @@ final class CustomerNoteTableViewCell: UITableViewCell {
         }
     }
 
+    /// Accessibility label to be used on the edit button, when shown
+    ///
+    var editButtonAccessibilityLabel: String? {
+        get {
+            editButton.accessibilityLabel
+        }
+        set {
+            editButton.accessibilityLabel = newValue
+        }
+    }
+
     override func awakeFromNib() {
         super.awakeFromNib()
         configureBackground()
@@ -55,6 +66,7 @@ final class CustomerNoteTableViewCell: UITableViewCell {
         headlineLabel.text = nil
         bodyLabel.text = nil
         onEditTapped = nil
+        editButton.accessibilityLabel = nil
     }
 }