POS: Fix retain cycles related to payment onboarding view (#15083)

Author: staskus

WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentOnboardingAdaptor.swift

@@ -9,7 +9,9 @@ final class CardPresentPaymentsOnboardingPresenterAdaptor: CardPresentPaymentsOn
 
     private let readinessUseCase: CardPresentPaymentsReadinessUseCase
 
-    private let onboardingViewModel: CardPresentPaymentsOnboardingViewModel
+    private var onboardingViewModel: CardPresentPaymentsOnboardingViewModel {
+        CardPresentPaymentsOnboardingViewModel(useCase: onboardingUseCase)
+    }
 
     private var readinessSubscription: AnyCancellable?
 
@@ -20,7 +22,6 @@ final class CardPresentPaymentsOnboardingPresenterAdaptor: CardPresentPaymentsOn
     init(stores: StoresManager = ServiceLocator.stores) {
         onboardingUseCase = CardPresentPaymentsOnboardingUseCase(stores: stores)
         readinessUseCase = CardPresentPaymentsReadinessUseCase(onboardingUseCase: onboardingUseCase, stores: stores)
-        onboardingViewModel = CardPresentPaymentsOnboardingViewModel(useCase: onboardingUseCase)
         onboardingScreenViewModelPublisher = onboardingScreenViewModelSubject.eraseToAnyPublisher()
     }
 

WooCommerce/Classes/POS/Models/PointOfSaleAggregateModel.swift

@@ -160,15 +160,15 @@ extension PointOfSaleAggregateModel {
 
     func connectCardReader() {
         analytics.track(.pointOfSaleCardReaderConnectionTapped)
-        Task { @MainActor in
-            _ = try await cardPresentPaymentService.connectReader(using: .bluetooth)
+        Task { @MainActor [weak self] in
+            _ = try await self?.cardPresentPaymentService.connectReader(using: .bluetooth)
         }
     }
 
     func disconnectCardReader() {
         analytics.track(.cardReaderDisconnectTapped)
-        Task { @MainActor in
-            await cardPresentPaymentService.disconnectReader()
+        Task { @MainActor [weak self] in
+            await self?.cardPresentPaymentService.disconnectReader()
         }
     }
 

WooCommerce/Classes/POS/Presentation/PointOfSaleDashboardView.swift

@@ -133,8 +133,8 @@ private extension PointOfSaleDashboardView {
     }
 
     func paymentsOnboardingView(from onboardingViewModel: CardPresentPaymentsOnboardingViewModel) -> some View {
-        onboardingViewModel.showSupport = {
-            posModel.cancelCardPaymentsOnboarding()
+        onboardingViewModel.showSupport = { [weak posModel] in
+            posModel?.cancelCardPaymentsOnboarding()
             showSupport = true
         }
         return PointOfSaleCardPresentPaymentOnboardingView(viewModel: .init(onboardingViewModel: onboardingViewModel,

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/CardPresentPaymentsOnboardingViewModel.swift

@@ -33,7 +33,9 @@ final class CardPresentPaymentsOnboardingViewModel: ObservableObject, PaymentSet
                 self?.updateLearnMoreURL(state: result)
                 self?.reevaluateShouldShow(onboardingState: result)
             })
-            .handleEvents(receiveOutput: trackState(_:))
+            .handleEvents(receiveOutput: { [weak self] state in
+                self?.trackState(state)
+            })
             .assign(to: &$state)
     }