Make synchronizeResources return Bool instead of Void

Author: itsmeichigo

Modules/Sources/Storage/Tools/StorageType+Extensions.swift

@@ -973,7 +973,7 @@ public extension StorageType {
         let descriptor = NSSortDescriptor(keyPath: \BookingResource.resourceID, ascending: false)
         return allObjects(ofType: BookingResource.self, matching: predicate, sortedBy: [descriptor])
     }
-    
+
     /// Retrieves the store booking resource
     func loadBookingResource(siteID: Int64, resourceID: Int64) -> BookingResource? {
         let predicate = \BookingResource.resourceID == resourceID && \BookingResource.siteID == siteID

Modules/Sources/Yosemite/Actions/BookingAction.swift

@@ -55,12 +55,12 @@ public enum BookingAction: Action {
 
     /// Synchronizes booking resources matching the specified criteria.
     ///
-    /// - Parameter onCompletion: called when sync completes, returns an error in case of a failure or empty in case of success.
+    /// - Parameter onCompletion: called when sync completes, returns an error or a boolean that indicates whether there might be more resources to sync.
     ///
     case synchronizeResources(siteID: Int64,
                              pageNumber: Int,
                              pageSize: Int = BookingsRemote.Default.pageSize,
-                             onCompletion: (Result<Void, Error>) -> Void)
+                             onCompletion: (Result<Bool, Error>) -> Void)
 
     /// Updates a booking attendance status.
     ///

Modules/Sources/Yosemite/Model/Model.swift

@@ -277,6 +277,7 @@ public typealias StorageBlazeTargetLanguage = Storage.BlazeTargetLanguage
 public typealias StorageBlazeTargetTopic = Storage.BlazeTargetTopic
 // periphery: ignore
 public typealias StorageBooking = Storage.Booking
+public typealias StorageBookingResource = Storage.BookingResource
 public typealias StorageCardReaderType = Storage.CardReaderType
 public typealias StorageCoupon = Storage.Coupon
 public typealias StorageCustomer = Storage.Customer

Modules/Sources/Yosemite/Stores/BookingStore.swift

@@ -261,7 +261,7 @@ private extension BookingStore {
     func synchronizeResources(siteID: Int64,
                              pageNumber: Int,
                              pageSize: Int,
-                             onCompletion: @escaping (Result<Void, Error>) -> Void) {
+                             onCompletion: @escaping (Result<Bool, Error>) -> Void) {
         Task { @MainActor in
             do {
                 let resources = try await remote.fetchResources(
@@ -273,7 +273,8 @@ private extension BookingStore {
                 await upsertBookingResourcesInBackground(siteID: siteID,
                                                          readOnlyBookingResources: resources)
 
-                onCompletion(.success(()))
+                let hasNextPage = resources.count == pageSize
+                onCompletion(.success(hasNextPage))
             } catch {
                 onCompletion(.failure(error))
             }

Modules/Tests/YosemiteTests/Stores/BookingStoreTests.swift

@@ -626,6 +626,55 @@ struct BookingStoreTests {
 
     // MARK: - synchronizeResources
 
+    @Test func synchronizeResources_returns_false_for_hasNextPage_when_number_of_retrieved_results_is_zero() async throws {
+        // Given
+        remote.whenFetchingResources(thenReturn: .success([]))
+        let store = BookingStore(dispatcher: Dispatcher(),
+                                 storageManager: storageManager,
+                                 network: network,
+                                 remote: remote,
+                                 ordersRemote: ordersRemote)
+
+        // When
+        let result = await withCheckedContinuation { continuation in
+            store.onAction(BookingAction.synchronizeResources(siteID: sampleSiteID,
+                                                              pageNumber: defaultPageNumber,
+                                                              pageSize: defaultPageSize,
+                                                              onCompletion: { result in
+                continuation.resume(returning: result)
+            }))
+        }
+
+        // Then
+        let hasNextPage = try result.get()
+        #expect(hasNextPage == false)
+    }
+
+    @Test func synchronizeResources_returns_true_for_hasNextPage_when_number_of_retrieved_results_equals_pageSize() async throws {
+        // Given
+        let resources = Array(repeating: BookingResource.fake(), count: defaultPageSize)
+        remote.whenFetchingResources(thenReturn: .success(resources))
+        let store = BookingStore(dispatcher: Dispatcher(),
+                                 storageManager: storageManager,
+                                 network: network,
+                                 remote: remote,
+                                 ordersRemote: ordersRemote)
+
+        // When
+        let result = await withCheckedContinuation { continuation in
+            store.onAction(BookingAction.synchronizeResources(siteID: sampleSiteID,
+                                                              pageNumber: defaultPageNumber,
+                                                              pageSize: defaultPageSize,
+                                                              onCompletion: { result in
+                continuation.resume(returning: result)
+            }))
+        }
+
+        // Then
+        let hasNextPage = try result.get()
+        #expect(hasNextPage == true)
+    }
+
     @Test func synchronizeResources_stores_resources_upon_success() async throws {
         // Given
         let resource = BookingResource.fake().copy(siteID: sampleSiteID, resourceID: 123)