Skip to content

Commit 6a95134

Browse files
Merge pull request #128 from woocommerce/issue/104-avoid-importing-networking
Avoiding Networking Imports
2 parents 6ad5f2d + 5bda16f commit 6a95134

File tree

9 files changed

+29
-15
lines changed

9 files changed

+29
-15
lines changed

WooCommerce/Classes/Authentication/AuthenticationManager.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import Foundation
22
import WordPressAuthenticator
33
import WordPressUI
4-
import Networking
4+
import Yosemite
55

66

77

WooCommerce/Classes/System/CredentialsManager.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import Foundation
2-
import Networking
2+
import Yosemite
33
import KeychainAccess
44

55

WooCommerce/Classes/Yosemite/StoresManager.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import Foundation
22
import Yosemite
33
import Storage
4-
import Networking
54

65

76

WooCommerce/WooCommerceTests/System/CredentialsManagerTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import XCTest
22
@testable import WooCommerce
3-
@testable import Networking
3+
import Yosemite
44

55

66
/// CredentialsManager Unit Tests

WooCommerce/WooCommerceTests/Yosemite/StoresManagerTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import XCTest
2+
import Networking
23
@testable import WooCommerce
3-
@testable import Networking
44

55

66
/// StoresManager Unit Tests

Yosemite/Yosemite.xcodeproj/project.pbxproj

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
74A7688E20D45ED400F9D437 /* OrderStoreTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 74A7688D20D45ED400F9D437 /* OrderStoreTests.swift */; };
1414
74A7689020D45F9300F9D437 /* OrderAction.swift in Sources */ = {isa = PBXBuildFile; fileRef = 74A7688F20D45F9300F9D437 /* OrderAction.swift */; };
1515
74A7689220D47F9E00F9D437 /* orders.json in Resources */ = {isa = PBXBuildFile; fileRef = 74A7689120D47F9E00F9D437 /* orders.json */; };
16+
B53D89E520E6C22B00F90866 /* Model.swift in Sources */ = {isa = PBXBuildFile; fileRef = B53D89E420E6C22B00F90866 /* Model.swift */; };
1617
B546CCF22093636A007CDA5F /* Yosemite.h in Headers */ = {isa = PBXBuildFile; fileRef = B546CCF12093636A007CDA5F /* Yosemite.h */; settings = {ATTRIBUTES = (Public, ); }; };
1718
B57A133220D2C787003D88DF /* StorageAccount+Extensions.swift in Sources */ = {isa = PBXBuildFile; fileRef = B57A133120D2C787003D88DF /* StorageAccount+Extensions.swift */; };
1819
B5A01CA120D19C4700E3207E /* MockupStorage.swift in Sources */ = {isa = PBXBuildFile; fileRef = B5A01CA020D19C4700E3207E /* MockupStorage.swift */; };
@@ -56,6 +57,7 @@
5657
93D120F57D5D14A10B3AFFFD /* Pods-Yosemite.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Yosemite.release.xcconfig"; path = "../Pods/Target Support Files/Pods-Yosemite/Pods-Yosemite.release.xcconfig"; sourceTree = "<group>"; };
5758
991BBCE6E4A92F0A028885D8 /* Pods_YosemiteTests.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_YosemiteTests.framework; sourceTree = BUILT_PRODUCTS_DIR; };
5859
ABE0D84C5393D9EE2CCF2B7E /* Pods-YosemiteTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-YosemiteTests.release.xcconfig"; path = "../Pods/Target Support Files/Pods-YosemiteTests/Pods-YosemiteTests.release.xcconfig"; sourceTree = "<group>"; };
60+
B53D89E420E6C22B00F90866 /* Model.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; name = Model.swift; path = Yosemite/Model/Model.swift; sourceTree = SOURCE_ROOT; };
5961
B546CCF12093636A007CDA5F /* Yosemite.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Yosemite.h; sourceTree = "<group>"; };
6062
B57A133120D2C787003D88DF /* StorageAccount+Extensions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "StorageAccount+Extensions.swift"; sourceTree = "<group>"; };
6163
B5A01CA020D19C4700E3207E /* MockupStorage.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = MockupStorage.swift; sourceTree = "<group>"; };
@@ -105,6 +107,14 @@
105107
/* End PBXFrameworksBuildPhase section */
106108

107109
/* Begin PBXGroup section */
110+
B53D89E720E6C7DC00F90866 /* Model */ = {
111+
isa = PBXGroup;
112+
children = (
113+
B53D89E420E6C22B00F90866 /* Model.swift */,
114+
);
115+
path = Model;
116+
sourceTree = "<group>";
117+
};
108118
B57A133020D2C770003D88DF /* Extensions */ = {
109119
isa = PBXGroup;
110120
children = (
@@ -188,6 +198,7 @@
188198
B57A133020D2C770003D88DF /* Extensions */,
189199
B5DC3CAF20D1B8660063AC41 /* Actions */,
190200
B5BC736320D1A98500B5B6FA /* Stores */,
201+
B53D89E720E6C7DC00F90866 /* Model */,
191202
B546CCF12093636A007CDA5F /* Yosemite.h */,
192203
B5C9DDF92087FEC0006B910A /* Info.plist */,
193204
);
@@ -442,6 +453,7 @@
442453
B5BC736520D1A98500B5B6FA /* AccountStore.swift in Sources */,
443454
B5B5C797208E49B600642956 /* Action+Internal.swift in Sources */,
444455
74A7688C20D45EBA00F9D437 /* OrderStore.swift in Sources */,
456+
B53D89E520E6C22B00F90866 /* Model.swift in Sources */,
445457
74A7689020D45F9300F9D437 /* OrderAction.swift in Sources */,
446458
B5C9DE182087FF0E006B910A /* Assert.swift in Sources */,
447459
B5C9DE162087FF0E006B910A /* Store.swift in Sources */,

Yosemite/Yosemite/Actions/AccountAction.swift

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,6 @@ import Networking
33

44

55

6-
// MARK: - Public Aliases
7-
//
8-
public typealias Account = Networking.Account
9-
10-
116
// MARK: - AccountAction: Defines all of the Actions supported by the AccountStore.
127
//
138
public enum AccountAction: Action {

Yosemite/Yosemite/Actions/OrderAction.swift

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,6 @@ import Networking
33

44

55

6-
// MARK: - Public Aliases
7-
//
8-
public typealias Order = Networking.Order
9-
10-
116
// MARK: - OrderAction: Defines all of the Actions supported by the OrderStore.
127
//
138
public enum OrderAction: Action {
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
import Foundation
2+
import Networking
3+
4+
5+
6+
// MARK: - Exported Symbols
7+
8+
public typealias Account = Networking.Account
9+
public typealias Address = Networking.Address
10+
public typealias Credentials = Networking.Credentials
11+
public typealias Order = Networking.Order
12+
public typealias OrderItem = Networking.OrderItem
13+
public typealias OrderStatus = Networking.OrderStatus

0 commit comments

Comments
 (0)