Cancel observation token of the same type before setting to another value.

jaclync · jaclync · commit 6f93ca49cf31 · 2020-05-01T13:10:46.000+08:00
diff --git a/WooCommerce/Classes/ViewRelated/Filters/FilterListViewController.swift b/WooCommerce/Classes/ViewRelated/Filters/FilterListViewController.swift
@@ -183,13 +183,15 @@ private extension FilterListViewController {
     }
 
     func observeListSelectorCommandItemSelection() {
+        cancellableSelectedFilterType?.cancel()
         cancellableSelectedFilterType = listSelectorCommand.onItemSelected.subscribe { [weak self] selected in
             guard let self = self else {
                 return
             }
 
             switch selected.listSelectorConfig {
             case .staticOptions(let options):
+                self.cancellableSelectedFilterValue?.cancel()
                 let command = StaticListSelectorCommand(navigationBarTitle: selected.title,
                                                         data: options,
                                                         selected: selected.selectedValue)

Original file line number	Diff line number	Diff line change
`@@ -183,13 +183,15 @@ private extension FilterListViewController {`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`func observeListSelectorCommandItemSelection() {`
	`186`	`+ cancellableSelectedFilterType?.cancel()`
`186`	`187`	`cancellableSelectedFilterType = listSelectorCommand.onItemSelected.subscribe { [weak self] selected in`
`187`	`188`	`guard let self = self else {`
`188`	`189`	`return`
`189`	`190`	`}`
`190`	`191`
`191`	`192`	`switch selected.listSelectorConfig {`
`192`	`193`	`case .staticOptions(let options):`
	`194`	`+ self.cancellableSelectedFilterValue?.cancel()`
`193`	`195`	`let command = StaticListSelectorCommand(navigationBarTitle: selected.title,`
`194`	`196`	`data: options,`
`195`	`197`	`selected: selected.selectedValue)`