Display error alert if package creation fails

Author: rachelmcr

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/Create Shipping Label Form/Package Details/Package Selection/Package Creation/ShippingLabelAddNewPackage.swift

@@ -77,8 +77,9 @@ struct ShippingLabelAddNewPackage: View {
                     })
                     .disabled(isSyncing)
                     .alert(isPresented: $showingAddPackageError, content: {
-                        Alert(title: Text(Localization.errorAlertTitle),
-                              message: Text(Localization.errorAlertMessage))
+                        let title = viewModel.error?.alertTitle ?? Localization.errorAlertTitle
+                        let message = viewModel.error?.errorDescription ?? Localization.errorAlertMessage
+                        return Alert(title: Text(title), message: Text(message))
                     })
                 })
             }
@@ -92,10 +93,9 @@ private extension ShippingLabelAddNewPackage {
         static let customPackage = NSLocalizedString("Custom Package", comment: "Custom Package menu in Shipping Label Add New Package flow")
         static let servicePackage = NSLocalizedString("Service Package", comment: "Service Package menu in Shipping Label Add New Package flow")
         static let doneButton = NSLocalizedString("Done", comment: "Done navigation button in the Add New Package screen in Shipping Label flow")
-        static let errorAlertTitle = NSLocalizedString("Cannot add package",
-                                                       comment: "Title of the alert when there is a failure adding a package in the Shipping Label flow")
+        static let errorAlertTitle = NSLocalizedString("Cannot add package", comment: "The title of the alert when there is a generic error adding the package")
         static let errorAlertMessage = NSLocalizedString("Unexpected error",
-                                                         comment: "Message of the alert when there is a failure adding a package in the Shipping Label flow")
+                                                         comment: "The message of the alert when there is an unexpected error adding the package")
     }
 }
 

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/Create Shipping Label Form/Package Details/Package Selection/Package Creation/ShippingLabelAddNewPackageViewModel.swift

@@ -38,6 +38,10 @@ final class ShippingLabelAddNewPackageViewModel: ObservableObject {
     ///
     private var packagesResponse: ShippingLabelPackagesResponse?
 
+    /// Error if package creation fails
+    ///
+    private(set) var error: PackageCreationError?
+
     /// Completion callback
     ///
     typealias Completion = (_ customPackage: ShippingLabelCustomPackage? ,
@@ -135,6 +139,7 @@ private extension ShippingLabelAddNewPackageViewModel {
                     onCompletion?(success)
                 }
             case .failure(let error):
+                self.error = error
                 DDLogError("⛔️ Error creating package: \(error.localizedDescription)")
                 onCompletion?(false)
             }