Skip to content

Commit 7026acb

Browse files
committed
Added some missing tracks events for magic links
1 parent 0b20213 commit 7026acb

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

WooCommerce/Classes/Analytics/WooAnalyticsStat.swift

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,14 @@ import WordPressShared
44
/// This enum contains all of the events we track in the app.
55
///
66
public enum WooAnalyticsStat: String {
7+
8+
// Application Events
9+
//
710
case applicationOpened = "application_opened"
811
case applicationClosed = "application_closed"
912

13+
// Authentication Events
14+
//
1015
case signedIn = "signed_in"
1116
case logout = "account_logout"
1217
case openedLogin = "login_accessed"
@@ -18,6 +23,11 @@ public enum WooAnalyticsStat: String {
1823
case loginEmailFormViewed = "login_email_form_viewed"
1924
case loginMagicLinkOpenEmailClientViewed = "login_magic_link_open_email_client_viewed"
2025
case loginMagicLinkRequestFormViewed = "login_magic_link_request_form_viewed"
26+
case loginMagicLinkExited = "login_magic_link_exited"
27+
case loginMagicLinkFailed = "login_magic_link_failed"
28+
case loginMagicLinkOpened = "login_magic_link_opened"
29+
case loginMagicLinkRequested = "login_magic_link_requested"
30+
case loginMagicLinkSucceeded = "login_magic_link_succeeded"
2131
case loginPasswordFormViewed = "login_password_form_viewed"
2232
case loginURLFormViewed = "login_url_form_viewed"
2333
case loginURLHelpScreenViewed = "login_url_help_screen_viewed"
@@ -78,6 +88,16 @@ public extension WooAnalyticsStat {
7888
wooEvent = WooAnalyticsStat.loginMagicLinkOpenEmailClientViewed
7989
case .loginMagicLinkRequestFormViewed:
8090
wooEvent = WooAnalyticsStat.loginMagicLinkRequestFormViewed
91+
case .loginMagicLinkExited:
92+
wooEvent = WooAnalyticsStat.loginMagicLinkExited
93+
case .loginMagicLinkFailed:
94+
wooEvent = WooAnalyticsStat.loginMagicLinkFailed
95+
case .loginMagicLinkOpened:
96+
wooEvent = WooAnalyticsStat.loginMagicLinkOpened
97+
case .loginMagicLinkRequested:
98+
wooEvent = WooAnalyticsStat.loginMagicLinkRequested
99+
case .loginMagicLinkSucceeded:
100+
wooEvent = WooAnalyticsStat.loginMagicLinkSucceeded
81101
case .loginPasswordFormViewed:
82102
wooEvent = WooAnalyticsStat.loginPasswordFormViewed
83103
case .loginURLFormViewed:

WooCommerce/Classes/Authentication/AuthenticationManager.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ extension AuthenticationManager: WordPressAuthenticatorDelegate {
191191
///
192192
func track(event: WPAnalyticsStat) {
193193
guard let wooEvent = WooAnalyticsStat.valueOf(stat: event) else {
194+
DDLogWarn("⚠️ Could not convert WPAnalyticsStat with value: \(event.rawValue)")
194195
return
195196
}
196197
WooAnalytics.shared.track(wooEvent)
@@ -200,6 +201,7 @@ extension AuthenticationManager: WordPressAuthenticatorDelegate {
200201
///
201202
func track(event: WPAnalyticsStat, properties: [AnyHashable: Any]) {
202203
guard let wooEvent = WooAnalyticsStat.valueOf(stat: event) else {
204+
DDLogWarn("⚠️ Could not convert WPAnalyticsStat with value: \(event.rawValue)")
203205
return
204206
}
205207
WooAnalytics.shared.track(wooEvent, withProperties: properties)
@@ -209,6 +211,7 @@ extension AuthenticationManager: WordPressAuthenticatorDelegate {
209211
///
210212
func track(event: WPAnalyticsStat, error: Error) {
211213
guard let wooEvent = WooAnalyticsStat.valueOf(stat: event) else {
214+
DDLogWarn("⚠️ Could not convert WPAnalyticsStat with value: \(event.rawValue)")
212215
return
213216
}
214217
WooAnalytics.shared.track(wooEvent, withError: error)

0 commit comments

Comments
 (0)