Remove the # from order searches

Author: rachelmcr

WooCommerce/Classes/ViewRelated/Search/Order/OrderSearchUICommand.swift

@@ -79,6 +79,18 @@ final class OrderSearchUICommand: SearchUICommand {
 
         viewController.navigationController?.pushViewController(detailsViewController, animated: true)
     }
+
+    /// Removes the `#` from the start of the search keyword, if present.
+    ///
+    /// This allows searching for an order with `#123` and getting the results for order `123`.
+    /// See https://github.com/woocommerce/woocommerce-ios/issues/2506
+    ///
+    func sanitize(_ keyword: String) -> String {
+        guard keyword.starts(with: "#") else {
+            return keyword
+        }
+        return keyword.removing(at: keyword.startIndex)
+    }
 }
 
 private extension OrderSearchUICommand {