Skip to content

Commit 71ce98d

Browse files
committed
Use different temporary icons for each note type.
1 parent 7c7ce78 commit 71ce98d

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

WooCommerce/Classes/ViewRelated/Inbox/InboxNoteRowViewModel.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,17 +64,17 @@ private extension InboxNoteRowViewModel {
6464
var image: Image {
6565
switch self {
6666
case .error:
67-
return Image(uiImage: .infoImage)
67+
return Image(systemName: "exclamationmark.octagon.fill")
6868
case .warning:
69-
return Image(uiImage: .infoImage)
69+
return Image(systemName: "exclamationmark.bubble.fill")
7070
case .update:
71-
return Image(uiImage: .infoImage)
71+
return Image(systemName: "gearshape.fill")
7272
case .info:
7373
return Image(uiImage: .infoImage)
7474
case .marketing:
7575
return Image(systemName: "lightbulb.fill")
7676
case .survey:
77-
return Image(uiImage: .infoImage)
77+
return Image(systemName: "doc.plaintext")
7878
}
7979
}
8080
}

WooCommerce/WooCommerceTests/ViewRelated/Inbox/InboxNoteRowViewModelTests.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@ final class InboxNoteRowViewModelTests: XCTestCase {
2727
// Given
2828
let types = ["error", "warning", "update", "info", "marketing", "survey"]
2929
// TODO: 5954 - update type icons after design updates
30-
let expectedTypeIcons = [Image(uiImage: .infoImage), // error
31-
Image(uiImage: .infoImage), // warning
32-
Image(uiImage: .infoImage), // update
33-
Image(uiImage: .infoImage), // info
34-
Image(systemName: "lightbulb.fill"), // marketing
35-
Image(uiImage: .infoImage) // survey
30+
let expectedTypeIcons = [Image(systemName: "exclamationmark.octagon.fill"), // error
31+
Image(systemName: "exclamationmark.bubble.fill"), // warning
32+
Image(systemName: "gearshape.fill"), // update
33+
Image(uiImage: .infoImage), // info
34+
Image(systemName: "lightbulb.fill"), // marketing
35+
Image(systemName: "doc.plaintext") // survey
3636
]
3737

3838
for (type, expectedTypeIcon) in zip(types, expectedTypeIcons) {

0 commit comments

Comments
 (0)