Fetch bookings upon opening details

Author: itsmeichigo

WooCommerce/Classes/ViewModels/Booking Details/BookingDetailsViewModel.swift

@@ -1,12 +1,10 @@
 import Foundation
 import Yosemite
-import protocol Storage.StorageManagerType
 
 final class BookingDetailsViewModel: ObservableObject {
     private let stores: StoresManager
 
     private var booking: Booking
-    private let storageManager: StorageManagerType
 
     // EntityListener: Update / Deletion Notifications.
     ///
@@ -17,12 +15,9 @@ final class BookingDetailsViewModel: ObservableObject {
     let navigationTitle: String
     @Published private(set) var sections: [Section] = []
 
-    init(booking: Booking,
-         stores: StoresManager = ServiceLocator.stores,
-         storageManager: StorageManagerType = ServiceLocator.storageManager) {
+    init(booking: Booking, stores: StoresManager = ServiceLocator.stores) {
         self.booking = booking
         self.stores = stores
-        self.storageManager = storageManager
 
         navigationTitle = Self.navigationTitle(for: booking)
         setupSections(with: booking)
@@ -108,12 +103,7 @@ private extension BookingDetailsViewModel {
                 siteID: booking.siteID,
                 bookingID: booking.bookingID
             ) { result in
-                switch result {
-                case .success:
-                    continuation.resume(returning: Void())
-                case .failure(let error):
-                    continuation.resume(throwing: error)
-                }
+                continuation.resume(with: result)
             }
             stores.dispatch(action)
         }

WooCommerce/Classes/ViewRelated/Bookings/Booking Details/BookingDetailsView.swift

@@ -46,6 +46,9 @@ struct BookingDetailsView: View {
         .refreshable {
             await viewModel.syncData()
         }
+        .task {
+            await viewModel.syncData()
+        }
         .navigationBarTitleDisplayMode(.inline)
         .navigationTitle(viewModel.navigationTitle)
         .background(Color(uiColor: .systemGroupedBackground))

WooCommerce/WooCommerceTests/ViewRelated/Bookings/BookingDetailsViewModelTests.swift

@@ -57,7 +57,7 @@ final class BookingDetailsViewModelTests: XCTestCase {
         let booking = Booking.fake().copy(orderInfo: orderInfo)
 
         // When
-        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager, storageManager: storageManager)
+        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager)
 
         // Then
         XCTAssertEqual(viewModel.sections.count, 6)
@@ -111,7 +111,7 @@ final class BookingDetailsViewModelTests: XCTestCase {
         let booking = Booking.fake().copy(orderInfo: orderInfo)
 
         // When
-        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager, storageManager: storageManager)
+        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager)
 
         // Then
         XCTAssertEqual(viewModel.sections.count, 5)
@@ -143,7 +143,7 @@ final class BookingDetailsViewModelTests: XCTestCase {
         let booking = Booking.fake().copy(orderInfo: orderInfo)
 
         // When
-        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager, storageManager: storageManager)
+        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager)
 
         // Then
         let headerSection = viewModel.sections.first { section in
@@ -186,7 +186,7 @@ final class BookingDetailsViewModelTests: XCTestCase {
         let booking = Booking.fake().copy(orderInfo: orderInfo)
 
         // When
-        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager, storageManager: storageManager)
+        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager)
 
         // Then
         let customerSection = viewModel.sections.first { section in
@@ -215,7 +215,7 @@ final class BookingDetailsViewModelTests: XCTestCase {
         let booking = Booking.fake().copy(bookingID: 12345)
 
         // When
-        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager, storageManager: storageManager)
+        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager)
 
         // Then
         XCTAssertTrue(viewModel.navigationTitle.contains("12345"))
@@ -224,7 +224,7 @@ final class BookingDetailsViewModelTests: XCTestCase {
     func test_syncData_triggers_booking_synchronization() async {
         // Given
         let booking = Booking.fake().copy(siteID: 123, bookingID: 456)
-        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager, storageManager: storageManager)
+        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager)
 
         let expectation = self.expectation(description: "Booking synchronization should be triggered")