Skip to content

Commit 72856ec

Browse files
authored
Merge pull request #7804 from woocommerce/issue/6564-remove-flag
Bulk Prices: Release feature
2 parents 11c2c2c + d0524ac commit 72856ec

File tree

5 files changed

+3
-8
lines changed

5 files changed

+3
-8
lines changed

Experiments/Experiments/DefaultFeatureFlagService.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
1111
return true
1212
case .inbox:
1313
return buildConfig == .localDeveloper || buildConfig == .alpha
14-
case .bulkEditProductVariations:
15-
return buildConfig == .localDeveloper || buildConfig == .alpha
1614
case .splitViewInOrdersTab:
1715
return buildConfig == .localDeveloper || buildConfig == .alpha
1816
case .updateOrderOptimistically:

Experiments/Experiments/FeatureFlag.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ public enum FeatureFlag: Int {
2222
///
2323
case inbox
2424

25-
/// Displays the bulk update option in product variations
26-
///
27-
case bulkEditProductVariations
28-
2925
/// Displays the Orders tab in a split view
3026
///
3127
case splitViewInOrdersTab

RELEASE-NOTES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
- [*] Settings: Display the WooCommerce version and available updates in Settings [https://github.com/woocommerce/woocommerce-ios/pull/7779]
99
- [*] Show suggestion for logging in to a WP.com site with a mismatched WP.com account. [https://github.com/woocommerce/woocommerce-ios/pull/7773]
1010
- [*] Help center: Added help center web page with FAQs for "Not a WooCommerce site" and "Wrong WordPress.com account" error screens. [https://github.com/woocommerce/woocommerce-ios/pull/7767, https://github.com/woocommerce/woocommerce-ios/pull/7769]
11+
- [*] Now you can bulk edit variation prices. [https://github.com/woocommerce/woocommerce-ios/pull/7803]
1112
- [**] Reviews: Now you can reply to product reviews using the Reply button while viewing a product review. [https://github.com/woocommerce/woocommerce-ios/pull/7799]
1213

1314
10.5

WooCommerce/Classes/ViewRelated/Products/Variations/ProductVariationsViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ private extension ProductVariationsViewController {
170170
/// Shows or hides the "more" navigation bar button.
171171
///
172172
func showOrHideMoreActionsNavigationBarButton() {
173-
guard featureFlagService.isFeatureFlagEnabled(.bulkEditProductVariations) && resultsController.fetchedObjects.isNotEmpty else {
173+
guard resultsController.fetchedObjects.isNotEmpty else {
174174
// Do not display the "more" button with the bulk update option if we do not have any variations
175175
hideMoreActionsNavigationBarButton()
176176
return

WooCommerce/WooCommerceTests/ViewRelated/Products/Variations/Bulk Update/BulkUpdateViewModelTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ final class BulkUpdateViewModelTests: XCTestCase {
350350
XCTAssertFalse(viewModel.shouldShowVariationLimitWarning)
351351
}
352352

353-
func test_more_than_100_variations_shows_shows_warning() throws {
353+
func test_more_than_100_variations_shows_warning() throws {
354354
// Given
355355
let viewModel = BulkUpdateViewModel(siteID: 0,
356356
productID: 0,

0 commit comments

Comments
 (0)