Move event call to view

iamgabrielma · iamgabrielma · commit 72a5eddd785b · 2025-02-19T09:36:39.000+01:00
The event is called wrongly when we create a new order, this is consequence of a side-effect of the system clearing the cart when a new order starts, which also triggers the event.
diff --git a/WooCommerce/Classes/POS/Models/PointOfSaleAggregateModel.swift b/WooCommerce/Classes/POS/Models/PointOfSaleAggregateModel.swift
@@ -135,7 +135,6 @@ extension PointOfSaleAggregateModel {
 
     func removeAllItemsFromCart() {
         cart.removeAll()
-        analytics.track(.pointOfSaleClearCartTapped)
     }
 
     func addMoreToCart() {
diff --git a/WooCommerce/Classes/POS/Presentation/CartView.swift b/WooCommerce/Classes/POS/Presentation/CartView.swift
@@ -47,6 +47,7 @@ struct CartView: View {
 
                     Button {
                         posModel.removeAllItemsFromCart()
+                        ServiceLocator.analytics.track(.pointOfSaleClearCartTapped)
                     } label: {
                         Text(Localization.clearButtonTitle)
                     }

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,6 @@ extension PointOfSaleAggregateModel {`
`135`	`135`
`136`	`136`	`func removeAllItemsFromCart() {`
`137`	`137`	`cart.removeAll()`
`138`		`- analytics.track(.pointOfSaleClearCartTapped)`
`139`	`138`	`}`
`140`	`139`
`141`	`140`	`func addMoreToCart() {`
Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@ struct CartView: View {`
`47`	`47`
`48`	`48`	`Button {`
`49`	`49`	`posModel.removeAllItemsFromCart()`
	`50`	`+ ServiceLocator.analytics.track(.pointOfSaleClearCartTapped)`
`50`	`51`	`} label: {`
`51`	`52`	`Text(Localization.clearButtonTitle)`
`52`	`53`	`}`