Add unit tests for validatedPackageAttributes

Author: itsmeichigo

WooCommerce/WooCommerceTests/ViewRelated/Shipping Label/Create Shipping Label/Multi-package/ShippingLabelPackageItemViewModelTests.swift

@@ -256,6 +256,73 @@ class ShippingLabelPackageItemViewModelTests: XCTestCase {
     }
 
     func test_isValidTotalWeight_returns_the_expected_value_when_the_totalWeight_is_not_valid() {
+        // Given
+        // Given
+        let order = MockOrders().makeOrder().copy(siteID: sampleSiteID, items: [])
+        let currencyFormatter = CurrencyFormatter(currencySettings: CurrencySettings())
+
+        let viewModel = ShippingLabelPackageItemViewModel(order: order,
+                                                          orderItems: order.items,
+                                                          packagesResponse: mockPackageResponse(),
+                                                          selectedPackageID: "Test Box",
+                                                          totalWeight: "10",
+                                                          products: [],
+                                                          productVariations: [],
+                                                          onPackageSwitch: { _ in },
+                                                          formatter: currencyFormatter,
+                                                          weightUnit: "kg")
+
+        // When
+        viewModel.totalWeight = "0.0"
+
+        // Then
+        XCTAssertFalse(viewModel.isValidTotalWeight)
+
+        // When
+        viewModel.totalWeight = "1..1"
+
+        // Then
+        XCTAssertFalse(viewModel.isValidTotalWeight)
+
+        // When
+        viewModel.totalWeight = "test"
+
+        // Then
+        XCTAssertFalse(viewModel.isValidTotalWeight)
+    }
+
+    func test_validatedPackageAttributes_returns_correct_value_when_total_weight_is_valid() {
+        // Given
+        let items = [MockOrderItem.sampleItem(name: "Easter Egg", productID: 1, quantity: 0.5)]
+        let order = MockOrders().makeOrder().copy(siteID: sampleSiteID, items: items)
+        let currencyFormatter = CurrencyFormatter(currencySettings: CurrencySettings())
+
+        // When
+        let product = Product.fake().copy(siteID: sampleSiteID, productID: 1, virtual: false, weight: "120")
+        let viewModel = ShippingLabelPackageItemViewModel(order: order,
+                                                          orderItems: order.items,
+                                                          packagesResponse: mockPackageResponse(),
+                                                          selectedPackageID: "Test Box",
+                                                          totalWeight: "10",
+                                                          products: [product],
+                                                          productVariations: [],
+                                                          onPackageSwitch: { _ in },
+                                                          formatter: currencyFormatter,
+                                                          weightUnit: "kg")
+
+        // Then
+        let expectedPackage1 = ShippingLabelPackageAttributes(packageID: "Test Box", totalWeight: "10", productIDs: [1])
+        XCTAssertEqual(viewModel.validatedPackageAttributes, expectedPackage1)
+
+        // When
+        viewModel.totalWeight = "12"
+
+        // Then
+        let expectedPackage2 = ShippingLabelPackageAttributes(packageID: "Test Box", totalWeight: "12", productIDs: [1])
+        XCTAssertEqual(viewModel.validatedPackageAttributes, expectedPackage2)
+    }
+
+    func test_validatedPackageAttributes_returns_nil_when_the_totalWeight_is_not_valid() {
         // Given
         // Given
         let items = [MockOrderItem.sampleItem(name: "Easter Egg", productID: 1, quantity: 0.5)]
@@ -278,19 +345,19 @@ class ShippingLabelPackageItemViewModelTests: XCTestCase {
         viewModel.totalWeight = "0.0"
 
         // Then
-        XCTAssertFalse(viewModel.isValidTotalWeight)
+        XCTAssertNil(viewModel.validatedPackageAttributes)
 
         // When
         viewModel.totalWeight = "1..1"
 
         // Then
-        XCTAssertFalse(viewModel.isValidTotalWeight)
+        XCTAssertNil(viewModel.validatedPackageAttributes)
 
         // When
         viewModel.totalWeight = "test"
 
         // Then
-        XCTAssertFalse(viewModel.isValidTotalWeight)
+        XCTAssertNil(viewModel.validatedPackageAttributes)
     }
 }
 

WooCommerce/WooCommerceTests/ViewRelated/Shipping Label/Create Shipping Label/Multi-package/ShippingLabelPackagesFormViewModelTests.swift

@@ -34,13 +34,13 @@ class ShippingLabelPackagesFormViewModelTests: XCTestCase {
         let package2 = ShippingLabelPackageAttributes(packageID: "Box 2", totalWeight: "5.5", productIDs: [1, 2, 3])
 
         // When & Then
-        let viewModel1 = ShippingLabelPackagesFormViewModel(order: order, packagesResponse: nil, selectedPackages: [])
+        let viewModel1 = ShippingLabelPackagesFormViewModel(order: order, packagesResponse: nil, selectedPackages: []) { _ in }
         XCTAssertFalse(viewModel1.foundMultiplePackages)
 
-        let viewModel2 = ShippingLabelPackagesFormViewModel(order: order, packagesResponse: nil, selectedPackages: [package1])
+        let viewModel2 = ShippingLabelPackagesFormViewModel(order: order, packagesResponse: nil, selectedPackages: [package1]) { _ in }
         XCTAssertFalse(viewModel2.foundMultiplePackages)
 
-        let viewModel3 = ShippingLabelPackagesFormViewModel(order: order, packagesResponse: nil, selectedPackages: [package1, package2])
+        let viewModel3 = ShippingLabelPackagesFormViewModel(order: order, packagesResponse: nil, selectedPackages: [package1, package2]) { _ in }
         XCTAssertTrue(viewModel3.foundMultiplePackages)
     }
 
@@ -50,7 +50,11 @@ class ShippingLabelPackagesFormViewModelTests: XCTestCase {
         insert(MockShippingLabelAccountSettings.sampleAccountSettings(siteID: sampleSiteID, lastSelectedPackageID: "package-1"))
 
         // When
-        let viewModel = ShippingLabelPackagesFormViewModel(order: order, packagesResponse: nil, selectedPackages: [], storageManager: storageManager)
+        let viewModel = ShippingLabelPackagesFormViewModel(order: order,
+                                                           packagesResponse: nil,
+                                                           selectedPackages: [],
+                                                           onCompletion: { _ in },
+                                                           storageManager: storageManager)
 
         // Then
         XCTAssertEqual(viewModel.itemViewModels.count, 1)
@@ -66,7 +70,7 @@ class ShippingLabelPackagesFormViewModelTests: XCTestCase {
         // When
         let viewModel = ShippingLabelPackagesFormViewModel(order: order,
                                                            packagesResponse: nil,
-                                                           selectedPackages: [package1, package2])
+                                                           selectedPackages: [package1, package2]) { _ in }
 
         // Then
         XCTAssertEqual(viewModel.itemViewModels.count, 2)