Merge pull request #7116 from woocommerce/issue/7106-coupons-empty-allowed-emails

Coupons: Allow empty email list

Author: itsmeichigo

WooCommerce/Classes/ViewRelated/Coupons/Add and Edit Coupons/UsageDetails/CouponAllowedEmailsViewModel.swift

@@ -24,7 +24,7 @@ final class CouponAllowedEmailsViewModel: ObservableObject {
     func validateEmails(dismissHandler: @escaping () -> Void) {
         let emails = emailPatterns.components(separatedBy: ", ")
         let foundInvalidPatterns = emails.contains(where: { !EmailFormatValidator.validate(string: $0) })
-        if !foundInvalidPatterns {
+        if emailPatterns.isEmpty || !foundInvalidPatterns {
             onCompletion(emailPatterns)
             dismissHandler()
         } else {

WooCommerce/Classes/ViewRelated/Coupons/Add and Edit Coupons/UsageDetails/CouponRestrictionsViewModel.swift

@@ -75,11 +75,11 @@ final class CouponRestrictionsViewModel: ObservableObject {
         }
     }()
 
-    lazy var allowedEmailsViewModel = {
+    var allowedEmailsViewModel: CouponAllowedEmailsViewModel {
         CouponAllowedEmailsViewModel(allowedEmails: allowedEmails) { [weak self] updatedEmails in
             self?.allowedEmails = updatedEmails
         }
-    }()
+    }
 
     private let siteID: Int64
     private let stores: StoresManager

WooCommerce/WooCommerceTests/ViewRelated/Coupons/CouponAllowedEmailsViewModelTests.swift

@@ -20,6 +20,23 @@ final class CouponAllowedEmailsViewModelTests: XCTestCase {
         XCTAssertNil(viewModel.notice)
     }
 
+    func test_completion_block_is_triggered_when_allowed_email_list_is_empty() {
+        // Given
+        var savedAddresses: String?
+        let completionBlock: (String) -> Void = { email in
+            savedAddresses = email
+        }
+        let viewModel = CouponAllowedEmailsViewModel(allowedEmails: "[email protected]", onCompletion: completionBlock)
+
+        // When
+        viewModel.emailPatterns = ""
+        viewModel.validateEmails {}
+
+        // Then
+        XCTAssertEqual(savedAddresses, "")
+        XCTAssertNil(viewModel.notice)
+    }
+
     func test_completion_block_is_not_triggered_and_notice_is_not_nil_when_address_validation_fails() {
         var savedAddresses: String?
         let completionBlock: (String) -> Void = { email in