Remove uneeded store settings

Author: ctarda

Storage/Storage/Model/Copiable/Models+Copiable.generated.swift

@@ -44,18 +44,15 @@ extension GeneralStoreSettings {
     public func copy(
         isTelemetryAvailable: CopiableProp<Bool> = .copy,
         telemetryLastReportedTime: NullableCopiableProp<Date> = .copy,
-        areSimplePaymentTaxesEnabled: CopiableProp<Bool> = .copy,
-        isStripeExtensionSelected: CopiableProp<Bool> = .copy
+        areSimplePaymentTaxesEnabled: CopiableProp<Bool> = .copy
     ) -> GeneralStoreSettings {
         let isTelemetryAvailable = isTelemetryAvailable ?? self.isTelemetryAvailable
         let telemetryLastReportedTime = telemetryLastReportedTime ?? self.telemetryLastReportedTime
         let areSimplePaymentTaxesEnabled = areSimplePaymentTaxesEnabled ?? self.areSimplePaymentTaxesEnabled
-        let isStripeExtensionSelected = isStripeExtensionSelected ?? self.isStripeExtensionSelected
 
         return GeneralStoreSettings(
             isTelemetryAvailable: isTelemetryAvailable,
             telemetryLastReportedTime: telemetryLastReportedTime,
-            isStripeExtensionSelected: isStripeExtensionSelected,
             areSimplePaymentTaxesEnabled: areSimplePaymentTaxesEnabled
         )
     }

Storage/Storage/Model/GeneralStoreSettings.swift

@@ -29,18 +29,11 @@ public struct GeneralStoreSettings: Codable, Equatable, GeneratedCopiable {
     ///
     public let areSimplePaymentTaxesEnabled: Bool
 
-    /// Indicates whether the merchant wants to use the Stripe Extension to process payments
-    ///
-    public let isStripeExtensionSelected: Bool
-
-
     public init(isTelemetryAvailable: Bool = false,
                 telemetryLastReportedTime: Date? = nil,
-                isStripeExtensionSelected: Bool = false,
                 areSimplePaymentTaxesEnabled: Bool = false) {
         self.isTelemetryAvailable = isTelemetryAvailable
         self.telemetryLastReportedTime = telemetryLastReportedTime
-        self.isStripeExtensionSelected = isStripeExtensionSelected
         self.areSimplePaymentTaxesEnabled = areSimplePaymentTaxesEnabled
     }
 }
@@ -53,7 +46,6 @@ extension GeneralStoreSettings {
         let container = try decoder.container(keyedBy: CodingKeys.self)
 
         self.isTelemetryAvailable = try container.decodeIfPresent(Bool.self, forKey: .isTelemetryAvailable) ?? false
-        self.isStripeExtensionSelected = try container.decodeIfPresent(Bool.self, forKey: .isStripeExtensionSelected) ?? false
         self.telemetryLastReportedTime = try container.decodeIfPresent(Date.self, forKey: .telemetryLastReportedTime)
         self.areSimplePaymentTaxesEnabled = try container.decodeIfPresent(Bool.self, forKey: .areSimplePaymentTaxesEnabled) ?? false
 

Yosemite/Yosemite/Actions/AppSettingsAction.swift

@@ -136,14 +136,6 @@ public enum AppSettingsAction: Action {
     ///
     case setStripeInPersonPaymentsSwitchState(isEnabled: Bool, onCompletion: (Result<Void, Error>) -> Void)
 
-    /// Loads a boolean flag indicating whether the Stripe extension is selected for a given store.
-    ///
-    case loadStripeExtensionAvailability(siteID: Int64, onCompletion: (Bool) -> Void)
-
-    /// Sets a boolean flag indicating whether the Stripe extension is selected for a given store.
-    ///
-    case setStripeExtensionAvailability(siteID: Int64, isAvailable: Bool, onCompletion: (Result<Void, Error>) -> Void)
-
     /// Sets the state for the Product SKU Input Scanner beta feature switch.
     ///
     case setProductSKUInputScannerFeatureSwitchState(isEnabled: Bool, onCompletion: (Result<Void, Error>) -> Void)

Yosemite/Yosemite/Stores/AppSettingsStore.swift

@@ -197,10 +197,6 @@ public class AppSettingsStore: Store {
             loadStripeInPersonPaymentsSwitchState(onCompletion: onCompletion)
         case .setStripeInPersonPaymentsSwitchState(isEnabled: let isEnabled, onCompletion: let onCompletion):
             setStripeInPersonPaymentsSwitchState(isEnabled: isEnabled, onCompletion: onCompletion)
-        case .loadStripeExtensionAvailability(siteID: let siteID, onCompletion: let onCompletion):
-            loadStripeExtensionAvailability(siteID: siteID, onCompletion: onCompletion)
-        case .setStripeExtensionAvailability(siteID: let siteID, isAvailable: let isAvailable, onCompletion: let onCompletion):
-            setStripeExtensionAvailability(siteID: siteID, isAvailable: isAvailable, onCompletion: onCompletion)
         case .setProductSKUInputScannerFeatureSwitchState(isEnabled: let isEnabled, onCompletion: let onCompletion):
             setProductSKUInputScannerFeatureSwitchState(isEnabled: isEnabled, onCompletion: onCompletion)
         case .loadProductSKUInputScannerFeatureSwitchState(onCompletion: let onCompletion):
@@ -319,17 +315,6 @@ private extension AppSettingsStore {
         }
     }
 
-    func loadStripeExtensionAvailability(siteID: Int64, onCompletion: @escaping (Bool) -> Void) {
-        let storeSettings = getStoreSettings(for: siteID)
-        onCompletion(storeSettings.isStripeExtensionSelected)
-    }
-
-    func setStripeExtensionAvailability(siteID: Int64, isAvailable: Bool, onCompletion: @escaping (Result<Void, Error>) -> Void) {
-        let storeSettings = getStoreSettings(for: siteID)
-        let updatedSettings = storeSettings.copy(isStripeExtensionSelected: isAvailable)
-        setStoreSettings(settings: updatedSettings, for: siteID, onCompletion: onCompletion)
-    }
-
     /// Sets the state for the Product SKU Input Scanner beta feature switch into `GeneralAppSettings`.
     ///
     func setProductSKUInputScannerFeatureSwitchState(isEnabled: Bool, onCompletion: (Result<Void, Error>) -> Void) {