Merge pull request #5446 from woocommerce/issue/5427-simplify-reader-update-available

allendav · web-flow · commit 8019f6557241 · 2021-11-17T10:16:45.000-08:00
[Mobile Payments] Simplify reader update check
diff --git a/WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/CardReaderSettingsConnectedViewController.swift b/WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/CardReaderSettingsConnectedViewController.swift
@@ -64,11 +64,11 @@ private extension CardReaderSettingsConnectedViewController {
         configureUpdateView()
     }
 
+    /// Returns `false` if no reader update is available or if  `viewModel` is `nil`.
+    /// Returns `true` otherwise.
+    ///
     func isReaderUpdateAvailable() -> Bool {
-        guard let viewModel = viewModel else {
-            return false
-        }
-        return viewModel.optionalReaderUpdateAvailable == true
+        viewModel?.optionalReaderUpdateAvailable == true
     }
 
     /// Set the title and back button.

Original file line number	Diff line number	Diff line change
`@@ -64,11 +64,11 @@ private extension CardReaderSettingsConnectedViewController {`
`64`	`64`	`configureUpdateView()`
`65`	`65`	`}`
`66`	`66`
	`67`	+ /// Returns `false` if no reader update is available or if `viewModel` is `nil`.
	`68`	+ /// Returns `true` otherwise.
	`69`	`+ ///`
`67`	`70`	`func isReaderUpdateAvailable() -> Bool {`
`68`		`- guard let viewModel = viewModel else {`
`69`		`- return false`
`70`		`- }`
`71`		`- return viewModel.optionalReaderUpdateAvailable == true`
	`71`	`+ viewModel?.optionalReaderUpdateAvailable == true`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`/// Set the title and back button.`