rename prop

Author: iamgabrielma

WooCommerce/Classes/Analytics/AppStartupWaitingTimeTracker.swift

@@ -5,7 +5,7 @@ import protocol WooFoundation.Analytics
 /// Tracks the waiting time for app startup, allowing to evaluate as analytics
 /// how much time in seconds it took between the init and the final `end(action:)` function call.
 ///
-class AppStartupWaitingTimeTracker: WaitingTimeTracker {
+final class AppStartupWaitingTimeTracker: WaitingTimeTracker {
 
     /// All actions tracked in the app startup waiting time.
     ///
@@ -21,8 +21,8 @@ class AppStartupWaitingTimeTracker: WaitingTimeTracker {
     private(set) var startupActionsPending = StartupAction.allCases
 
     init(analyticsService: Analytics = ServiceLocator.analytics,
-         currentTimeInMillis: @escaping () -> TimeInterval = { Date().timeIntervalSince1970 }) {
-        super.init(trackScenario: .appStartup, analyticsService: analyticsService, currentTime: currentTimeInMillis)
+         currentTimestampSeconds: @escaping () -> TimeInterval = { Date().timeIntervalSince1970 }) {
+        super.init(trackScenario: .appStartup, analyticsService: analyticsService, currentTimestampSeconds: currentTimestampSeconds)
     }
 
     /// Ends the waiting time for the provided startup action.

WooCommerce/Classes/Analytics/WaitingTimeTracker.swift

@@ -7,25 +7,25 @@ import protocol WooFoundation.Analytics
 ///
 class WaitingTimeTracker {
     private let trackScenario: WooAnalyticsEvent.WaitingTime.Scenario
-    private let currentTime: () -> TimeInterval
+    private let currentTimestampSeconds: () -> TimeInterval
     private let analyticsService: Analytics
     private let waitingStartedTimestamp: TimeInterval
 
     init(trackScenario: WooAnalyticsEvent.WaitingTime.Scenario,
          analyticsService: Analytics = ServiceLocator.analytics,
-         currentTime: @escaping () -> TimeInterval = { Date().timeIntervalSince1970 }
+         currentTimestampSeconds: @escaping () -> TimeInterval = { Date().timeIntervalSince1970 }
     ) {
         self.trackScenario = trackScenario
         self.analyticsService = analyticsService
-        self.currentTime = currentTime
-        waitingStartedTimestamp = currentTime()
+        self.currentTimestampSeconds = currentTimestampSeconds
+        waitingStartedTimestamp = currentTimestampSeconds()
     }
 
     /// End the waiting time by evaluating the elapsed time from the init,
     /// and sending it as an analytics event, in seconds.
     ///
     func end() {
-        let elapsedTime = currentTime() - waitingStartedTimestamp
+        let elapsedTime = currentTimestampSeconds() - waitingStartedTimestamp
         let analyticsEvent = WooAnalyticsEvent.WaitingTime.waitingFinished(scenario: trackScenario, elapsedTime: elapsedTime)
         analyticsService.track(event: analyticsEvent)
     }
@@ -34,7 +34,7 @@ class WaitingTimeTracker {
     /// and sending it as an analytics event, in milliseconds
     ///
     func endInMilliseconds() {
-        let elapsedTimeMs = (currentTime() - waitingStartedTimestamp) * 1000
+        let elapsedTimeMs = (currentTimestampSeconds() - waitingStartedTimestamp) * 1000
         let analyticsEvent = WooAnalyticsEvent.WaitingTime.waitingFinished(scenario: trackScenario, elapsedTime: elapsedTimeMs)
         analyticsService.track(event: analyticsEvent)
     }

WooCommerce/WooCommerceTests/System/WaitingTimeTrackerTests.swift

@@ -26,7 +26,7 @@ class WaitingTimeTrackerTests: XCTestCase {
 
     func testOrderDetailsTrackScenarioTriggersExpectedAnalyticsStat() {
         // Given
-        let waitingTracker = WaitingTimeTracker(trackScenario: .orderDetails, analyticsService: testAnalytics, currentTime: { 0 })
+        let waitingTracker = WaitingTimeTracker(trackScenario: .orderDetails, analyticsService: testAnalytics, currentTimestampSeconds: { 0 })
 
         // When
         waitingTracker.end()
@@ -39,7 +39,7 @@ class WaitingTimeTrackerTests: XCTestCase {
         // Given
         let waitingTracker = WaitingTimeTracker(trackScenario: .dashboardTopPerformers,
                                                 analyticsService: testAnalytics,
-                                                currentTime: { 0 }
+                                                currentTimestampSeconds: { 0 }
         )
 
         // When
@@ -53,7 +53,7 @@ class WaitingTimeTrackerTests: XCTestCase {
         // Given
         let waitingTracker = WaitingTimeTracker(trackScenario: .dashboardMainStats,
                                                 analyticsService: testAnalytics,
-                                                currentTime: { 0 }
+                                                currentTimestampSeconds: { 0 }
         )
 
         // When
@@ -67,7 +67,7 @@ class WaitingTimeTrackerTests: XCTestCase {
         // Given
         let waitingTracker = WaitingTimeTracker(trackScenario: .analyticsHub,
                                                 analyticsService: testAnalytics,
-                                                currentTime: { 0 }
+                                                currentTimestampSeconds: { 0 }
         )
 
         // When
@@ -81,7 +81,7 @@ class WaitingTimeTrackerTests: XCTestCase {
         // Given
         let waitingTracker = WaitingTimeTracker(trackScenario: .appStartup,
                                                 analyticsService: testAnalytics,
-                                                currentTime: { 0 }
+                                                currentTimestampSeconds: { 0 }
         )
 
         // When