Skip to content

Commit 837466f

Browse files
authored
Merge pull request #6184 from woocommerce/feat/5954-inbox-empty-image
Inbox view part 4: update empty state image
2 parents bc43663 + e5cb9d2 commit 837466f

File tree

6 files changed

+36
-1
lines changed

6 files changed

+36
-1
lines changed

WooCommerce/Classes/Extensions/UIImage+Woo.swift

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,12 @@ extension UIImage {
228228
return UIImage(named: "woo-empty-coupons")!
229229
}
230230

231+
/// Empty Inbox Notes Icon
232+
///
233+
static var emptyInboxNotesImage: UIImage {
234+
UIImage(named: "woo-empty-inbox-notes")!
235+
}
236+
231237
/// Empty Products Icon
232238
///
233239
static var emptyProductsImage: UIImage {

WooCommerce/Classes/ViewRelated/Inbox/Inbox.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ struct Inbox: View {
2626
// TODO: 5954 - update empty state
2727
EmptyState(title: Localization.emptyStateTitle,
2828
description: Localization.emptyStateMessage,
29-
image: .emptyProductsTabImage)
29+
image: .emptyInboxNotesImage)
3030
.frame(maxHeight: .infinity)
3131
case .syncingFirstPage:
3232
ScrollView {
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
{
2+
"images" : [
3+
{
4+
"filename" : "woo-empty-inbox-notes-light.pdf",
5+
"idiom" : "universal"
6+
},
7+
{
8+
"appearances" : [
9+
{
10+
"appearance" : "luminosity",
11+
"value" : "dark"
12+
}
13+
],
14+
"filename" : "woo-empty-inbox-notes-dark.pdf",
15+
"idiom" : "universal"
16+
}
17+
],
18+
"info" : {
19+
"author" : "xcode",
20+
"version" : 1
21+
},
22+
"properties" : {
23+
"preserves-vector-representation" : true
24+
}
25+
}

WooCommerce/WooCommerceTests/Extensions/IconsTests.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,10 @@ final class IconsTests: XCTestCase {
128128
XCTAssertNotNil(UIImage.emptyCouponsImage)
129129
}
130130

131+
func test_empty_inbox_notes_image_icon_is_not_nil() {
132+
XCTAssertNotNil(UIImage.emptyInboxNotesImage)
133+
}
134+
131135
func testEmptyProductsImageIconIsNotNil() {
132136
XCTAssertNotNil(UIImage.emptyProductsImage)
133137
}

0 commit comments

Comments
 (0)