Move reset tap counter to analytics tracker

iamgabrielma · iamgabrielma · commit 84c1df29697f · 2025-02-18T14:22:44.000+01:00
diff --git a/WooCommerce/Classes/POS/Analytics/POSCollectOrderPaymentAnalytics.swift b/WooCommerce/Classes/POS/Analytics/POSCollectOrderPaymentAnalytics.swift
@@ -51,6 +51,7 @@ final class POSCollectOrderPaymentAnalytics: CollectOrderPaymentAnalyticsTrackin
         analytics.track(event: .PointOfSale.cashCollectPaymentSuccess(
             millisecondsSinceCustomerIteractionStarted: elapsedTimeSinceCustomerInteraction
         ))
+        resetCheckoutTapCountTracker()
     }
 
     func trackPaymentFailure(with error: any Error) { }
diff --git a/WooCommerce/Classes/POS/Models/PointOfSaleAggregateModel.swift b/WooCommerce/Classes/POS/Models/PointOfSaleAggregateModel.swift
@@ -252,8 +252,6 @@ extension PointOfSaleAggregateModel {
     private func cashPaymentSuccess() {
         paymentState = .cash(.paymentSuccess)
         collectOrderPaymentAnalyticsTracker.trackSuccessfulCashPayment()
-        // TODO: Move to trackSuccessfulCashPayment() on #15151
-        collectOrderPaymentAnalyticsTracker.resetCheckoutTapCountTracker()
     }
 
     @MainActor

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,7 @@ final class POSCollectOrderPaymentAnalytics: CollectOrderPaymentAnalyticsTrackin`
`51`	`51`	`analytics.track(event: .PointOfSale.cashCollectPaymentSuccess(`
`52`	`52`	`millisecondsSinceCustomerIteractionStarted: elapsedTimeSinceCustomerInteraction`
`53`	`53`	`))`
	`54`	`+ resetCheckoutTapCountTracker()`
`54`	`55`	`}`
`55`	`56`
`56`	`57`	`func trackPaymentFailure(with error: any Error) { }`
Original file line number	Diff line number	Diff line change
`@@ -252,8 +252,6 @@ extension PointOfSaleAggregateModel {`
`252`	`252`	`private func cashPaymentSuccess() {`
`253`	`253`	`paymentState = .cash(.paymentSuccess)`
`254`	`254`	`collectOrderPaymentAnalyticsTracker.trackSuccessfulCashPayment()`
`255`		`- // TODO: Move to trackSuccessfulCashPayment() on #15151`
`256`		`- collectOrderPaymentAnalyticsTracker.resetCheckoutTapCountTracker()`
`257`	`255`	`}`
`258`	`256`
`259`	`257`	`@MainActor`