Introduce updateRightBarButtonItem method for simplicity.

Sharma Elanthiriayan · Sharma Elanthiriayan · commit 859e44fcbb80 · 2022-01-07T08:47:05.000+05:30
diff --git a/WooCommerce/Classes/ViewRelated/Reviews/ReviewsViewController.swift b/WooCommerce/Classes/ViewRelated/Reviews/ReviewsViewController.swift
@@ -276,7 +276,7 @@ private extension ReviewsViewController {
                 tracks.track(.reviewsMarkAllReadSuccess)
             }
 
-            self.updateMenuButtonState()
+            self.updateRightBarButtonItem()
             self.tableView.reloadData()
         }
     }
@@ -414,7 +414,7 @@ private extension ReviewsViewController {
     /// Note: Just because this func runs does not guarantee `didEnter()` or `didLeave()` will run as well.
     ///
     func willEnter(state: State) {
-        updateNavBarButtonsState()
+        updateRightBarButtonItem()
     }
 
     /// Runs whenever the FSM enters a State.
@@ -480,13 +480,9 @@ private extension ReviewsViewController {
 //
 private extension ReviewsViewController {
 
-    func updateNavBarButtonsState() {
-        updateMenuButtonState()
-    }
-
     /// Show the rightBarButtonItem only if there are unread reviews available.
     ///
-    func updateMenuButtonState() {
+    func updateRightBarButtonItem() {
         navigationItem.rightBarButtonItem = viewModel.hasUnreadNotifications ? rightBarButton : nil
     }
 

Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,7 @@ private extension ReviewsViewController {`
`276`	`276`	`tracks.track(.reviewsMarkAllReadSuccess)`
`277`	`277`	`}`
`278`	`278`
`279`		`- self.updateMenuButtonState()`
	`279`	`+ self.updateRightBarButtonItem()`
`280`	`280`	`self.tableView.reloadData()`
`281`	`281`	`}`
`282`	`282`	`}`
`@@ -414,7 +414,7 @@ private extension ReviewsViewController {`
`414`	`414`	/// Note: Just because this func runs does not guarantee `didEnter()` or `didLeave()` will run as well.
`415`	`415`	`///`
`416`	`416`	`func willEnter(state: State) {`
`417`		`- updateNavBarButtonsState()`
	`417`	`+ updateRightBarButtonItem()`
`418`	`418`	`}`
`419`	`419`
`420`	`420`	`/// Runs whenever the FSM enters a State.`
`@@ -480,13 +480,9 @@ private extension ReviewsViewController {`
`480`	`480`	`//`
`481`	`481`	`private extension ReviewsViewController {`
`482`	`482`
`483`		`- func updateNavBarButtonsState() {`
`484`		`- updateMenuButtonState()`
`485`		`- }`
`486`		`-`
`487`	`483`	`/// Show the rightBarButtonItem only if there are unread reviews available.`
`488`	`484`	`///`
`489`		`- func updateMenuButtonState() {`
	`485`	`+ func updateRightBarButtonItem() {`
`490`	`486`	`navigationItem.rightBarButtonItem = viewModel.hasUnreadNotifications ? rightBarButton : nil`
`491`	`487`	`}`
`492`	`488`