Skip to content

Commit 873549a

Browse files
authored
Merge pull request #7672 from woocommerce/remove-unused-ios-version-in-ui-tests
Remove ios_version parameter from test_without_building lane
2 parents f02178a + 68ec4d2 commit 873549a

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

.buildkite/commands/run-ui-tests.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22

33
TEST_NAME=$1
44
DEVICE=$2
5-
IOS_VERSION=$3
65

7-
echo "Running $TEST_NAME on $DEVICE for iOS $IOS_VERSION"
6+
echo "Running $TEST_NAME on $DEVICE"
87

98
# Run this at the start to fail early if value not available
109
echo '--- :test-analytics: Configuring Test Analytics'
@@ -36,7 +35,7 @@ echo "--- 🧪 Testing"
3635
xcrun simctl list >> /dev/null
3736
rake mocks &
3837
set +e
39-
bundle exec fastlane test_without_building name:"$TEST_NAME" device:"$DEVICE" ios_version:"$IOS_VERSION"
38+
bundle exec fastlane test_without_building name:"$TEST_NAME" device:"$DEVICE"
4039
TESTS_EXIT_STATUS=$?
4140
set -e
4241

.buildkite/pipeline.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ steps:
6868
# UI Tests
6969
#################
7070
- label: "🔬 UI Tests (iPhone)"
71-
command: .buildkite/commands/run-ui-tests.sh UITests 'iPhone 11' 15.0
71+
command: .buildkite/commands/run-ui-tests.sh UITests 'iPhone 11'
7272
depends_on: "build"
7373
env: *common_env
7474
plugins: *common_plugins
@@ -79,7 +79,7 @@ steps:
7979
context: "UI Tests (iPhone)"
8080

8181
- label: "🔬 UI Tests (iPad)"
82-
command: .buildkite/commands/run-ui-tests.sh UITests "iPad Air (5th generation)" 15.0
82+
command: .buildkite/commands/run-ui-tests.sh UITests "iPad Air (5th generation)"
8383
depends_on: "build"
8484
env: *common_env
8585
plugins: *common_plugins

fastlane/Fastfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1075,7 +1075,6 @@ lane :test_without_building do |options|
10751075
workspace: 'WooCommerce.xcworkspace',
10761076
scheme: TEST_SCHEME,
10771077
device: options[:device],
1078-
deployment_target_version: options[:ios_version],
10791078
test_without_building: true,
10801079
xctestrun: xctestrun_path,
10811080
result_bundle: true,

0 commit comments

Comments
 (0)