The closure does not need to be optional

toupper · toupper · commit 8afa16eb7089 · 2022-06-09T15:47:17.000+02:00
diff --git a/WooCommerce/Classes/ViewModels/Order Details/OrderDetailsViewModel.swift b/WooCommerce/Classes/ViewModels/Order Details/OrderDetailsViewModel.swift
@@ -607,12 +607,12 @@ extension OrderDetailsViewModel {
         stores.dispatch(action)
     }
 
-    func checkCardPresentPaymentEligibility(onCompletion: (() -> Void)? = nil) {
+    func checkCardPresentPaymentEligibility(onCompletion: @escaping (() -> Void)) {
         let configuration = configurationLoader.configuration
 
         guard configuration.isSupportedCountry else {
             dataSource.isEligibleForCardPresentPayment = false
-            onCompletion?()
+            onCompletion()
             return
         }
 
@@ -627,7 +627,7 @@ extension OrderDetailsViewModel {
                 self?.dataSource.isEligibleForCardPresentPayment = false
             }
 
-            onCompletion?()
+            onCompletion()
         }
 
         stores.dispatch(action)

Original file line number	Diff line number	Diff line change
`@@ -607,12 +607,12 @@ extension OrderDetailsViewModel {`
`607`	`607`	`stores.dispatch(action)`
`608`	`608`	`}`
`609`	`609`
`610`		`- func checkCardPresentPaymentEligibility(onCompletion: (() -> Void)? = nil) {`
	`610`	`+ func checkCardPresentPaymentEligibility(onCompletion: @escaping (() -> Void)) {`
`611`	`611`	`let configuration = configurationLoader.configuration`
`612`	`612`
`613`	`613`	`guard configuration.isSupportedCountry else {`
`614`	`614`	`dataSource.isEligibleForCardPresentPayment = false`
`615`		`- onCompletion?()`
	`615`	`+ onCompletion()`
`616`	`616`	`return`
`617`	`617`	`}`
`618`	`618`
`@@ -627,7 +627,7 @@ extension OrderDetailsViewModel {`
`627`	`627`	`self?.dataSource.isEligibleForCardPresentPayment = false`
`628`	`628`	`}`
`629`	`629`
`630`		`- onCompletion?()`
	`630`	`+ onCompletion()`
`631`	`631`	`}`
`632`	`632`
`633`	`633`	`stores.dispatch(action)`